From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: org-agenda-filter-by-tag-refine defaults to exclude Date: Fri, 29 Jan 2016 19:57:56 -0500 Message-ID: <87h9hvg9yj.fsf@kyleam.com> References: <29B5D2C5-E59B-4E8D-9669-67F24C0B7C60@gmx.de> <87a8obl3r7.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPJre-0001rQ-4r for emacs-orgmode@gnu.org; Fri, 29 Jan 2016 19:58:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPJrZ-0004jw-4R for emacs-orgmode@gnu.org; Fri, 29 Jan 2016 19:58:10 -0500 Received: from pb-smtp0.int.icgroup.com ([208.72.237.35]:62398 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPJrY-0004jR-Vp for emacs-orgmode@gnu.org; Fri, 29 Jan 2016 19:58:05 -0500 In-Reply-To: ("Gustav =?utf-8?Q?Wikstr=C3=B6m=22's?= message of "Thu, 28 Jan 2016 08:27:19 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Gustav =?utf-8?Q?Wikstr=C3=B6m?= Cc: Viktor Rosenfeld , "emacs-orgmode@gnu.org" Hi Gustav, Gustav Wikstr=C3=B6m writes: [...] > If you want to make any change, Given that, as of 6c6ae99, the function's behavior doesn't match its name or its previous behavior, I don't think leaving it unchanged is a good option. > I'd suggest to instead change the name > of org-agenda-filter-by-tag-refine to org-agenda-filter-by-tag-exclude > and to leave the code within the function as is (well.. maybe change > 'refine to 'exclude with the same argument as to the function name > change). Like Viktor, I'm in favor of just removing it, because both its old and new behavior are easily accomplished with the current org-agenda-filter-by-tag. This already made it into a release (v8.3), so in maint I plan to remove the refine (now exclude) argument from org-agenda-filter-by-tag-refine's call to org-agenda-filter-by-tag. I think that gets the function as close as we can to the old behavior without making any major changes. In master, I'll just remove org-agenda-filter-by-tag-refine. I'll make those changes in a few days unless someone objects. -- Kyle