From: Kyle Meyer <kyle@kyleam.com>
To: "Gustav Wikström" <gustav@whil.se>
Cc: Viktor Rosenfeld <v.rosenfeld@gmx.de>,
"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: org-agenda-filter-by-tag-refine defaults to exclude
Date: Fri, 29 Jan 2016 19:57:56 -0500 [thread overview]
Message-ID: <87h9hvg9yj.fsf@kyleam.com> (raw)
In-Reply-To: <DB5PR02MB119170059AB8DECA3150440ADADA0@DB5PR02MB1191.eurprd02.prod.outlook.com> ("Gustav Wikström"'s message of "Thu, 28 Jan 2016 08:27:19 +0000")
Hi Gustav,
Gustav Wikström <gustav@whil.se> writes:
[...]
> If you want to make any change,
Given that, as of 6c6ae99, the function's behavior doesn't match its
name or its previous behavior, I don't think leaving it unchanged is a
good option.
> I'd suggest to instead change the name
> of org-agenda-filter-by-tag-refine to org-agenda-filter-by-tag-exclude
> and to leave the code within the function as is (well.. maybe change
> 'refine to 'exclude with the same argument as to the function name
> change).
Like Viktor, I'm in favor of just removing it, because both its old and
new behavior are easily accomplished with the current
org-agenda-filter-by-tag.
This already made it into a release (v8.3), so in maint I plan to remove
the refine (now exclude) argument from org-agenda-filter-by-tag-refine's
call to org-agenda-filter-by-tag. I think that gets the function as
close as we can to the old behavior without making any major changes.
In master, I'll just remove org-agenda-filter-by-tag-refine.
I'll make those changes in a few days unless someone objects.
--
Kyle
prev parent reply other threads:[~2016-01-30 0:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 7:42 org-agenda-filter-by-tag-refine defaults to exclude Viktor Rosenfeld
2016-01-12 6:18 ` Kyle Meyer
2016-01-28 8:27 ` Gustav Wikström
2016-01-29 23:07 ` Viktor Rosenfeld
2016-01-31 18:50 ` Gustav Wikström
2016-01-30 0:57 ` Kyle Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9hvg9yj.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=gustav@whil.se \
--cc=v.rosenfeld@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.