From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: master 0883e98 1/3: New functions for getting and setting image properties Date: Mon, 22 Feb 2016 14:15:39 +0100 Message-ID: <87h9h0ant0.fsf@web.de> References: <20160220070344.25183.28197@vcs.savannah.gnu.org> <87fuwndeme.fsf@gnus.org> <87twl3e2qo.fsf@web.de> <87ziuuiyo5.fsf@gnus.org> <87twl2i8g5.fsf@web.de> <87egc5bk04.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456146986 25454 80.91.229.3 (22 Feb 2016 13:16:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Feb 2016 13:16:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 22 14:16:18 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aXqLY-0002tn-0T for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 14:16:16 +0100 Original-Received: from localhost ([::1]:49129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXqLX-0001Xk-Cg for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 08:16:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXqL6-0001QZ-8r for emacs-devel@gnu.org; Mon, 22 Feb 2016 08:15:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXqL2-0004nA-1q for emacs-devel@gnu.org; Mon, 22 Feb 2016 08:15:47 -0500 Original-Received: from mout.web.de ([212.227.15.14]:60374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXqL1-0004mz-Od for emacs-devel@gnu.org; Mon, 22 Feb 2016 08:15:43 -0500 Original-Received: from drachen.dragon ([92.74.189.190]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0Lgb2b-1aCrRh3cLV-00nx0V; Mon, 22 Feb 2016 14:15:41 +0100 In-Reply-To: <87egc5bk04.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 22 Feb 2016 12:40:11 +1100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (gnu/linux) X-Provags-ID: V03:K0:tyT5t8tb5vBtsv7BUWyQINx0lx/BlwfYU8KKkRmDAD0zFHH7wEC Yo3zH/Qdxw4awD/bPVcFpkylyli+47eXxM5WYKb4jrBL7L2ChIAZ8ZMRmvkfwhh60x+kS7y oyEcqQIfDjrwTqnUPLnpmTLP94dp7IvYh+TK6wscaQhbTDP5tXpPMfftqELY6itRAzJduA8 mRbCeh3BHFTJuPB80Q/ag== X-UI-Out-Filterresults: notjunk:1;V01:K0:H3Cfm8xUe3o=:EPXkznQvgieDB4TDnQa/nR gYlyoVjqm9YfOVYmaIyYvD9vC4RiLilejWBuBILyTR/QvYEqsfXGeZfM3sAsiUUbYYh0IBxjJ zP86XEqLUowlDe4276dzO+SGw07FYl7gzd9iL7Iocih6TbhWqYm0epQLBVfmnXMj+q2gijLBU c2bU9bjzUvnNGOgLIwgZaT9VB5NgL+WzuqzWSVkS+g+J6j8wfWPjp9QZNKWW2mPiWovJwPwn8 sK6rzQIPle9YzYMIgRWgi0i1sG/CZGdV/IKcNuQs2eL6tld6MXoma7mlRgTfhv1s967VNjl+L yslsGQFnElpysF9AZfjp+HVlkwtKZR+O20z9Pk37mKfTURXckiyQP4YiCQ7fjhJw71yV8uebo gRivcNJTfTmZuRXFfCAcbFI1TTbv9PHJgexReS2zwb/VI6Yrr2sIkq7nvbNu1Ko1gb4gwu6PH XnewKWUVkrEBAeahRQseg2RKSXNk4mS9ZAPMDkadI5UMgdgnGEWXc0SvmhZylXRMk1Z04S6YF koJE1m3lOjnqsorgnLx0y5jhiwNNBGyxrZJxjdx6JefEhmiYD1Cct6lSNdfSPI+r13gt3kmaj 3dX+oTz4jsEvg26Vdfr5YKuzAvZSeLLYjawsciHuMNpRM++C8DkKCrEwMd6tBdP+NP4Petvwf vVNpcsakisdTDGOjYkdplATGsCXGxjY4HO4Ctjk/ok7brd/ISZmS4csfZO3htE2cpcmyWW9mW DxwlIRu8D2f+n2MeHZaHlAU89tqzx7iDtH/QU7vBvTsVIhLpTj/0uKm7PjcCnK6R7OhGcIca X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.14 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200452 Archived-At: Lars Ingebrigtsen writes: > Great! I'll rewrite those two getter/setter functions to be more > setf-ey. Looks ok. Nitpick: according to the doc of `gv-define-simple-setter', to "preserve the semantics of setf" `image--set-property' should either return the VALUE. Or use (declare (gv-setter image--set-property t)) ^ Hmm, this DTRT, though it's not documented in (info "(elisp) Declare Form") Will file a bug report... Regards, Michael.