From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#22893: 25.1.50; dired-get-marked-files get all marked Date: Thu, 10 Mar 2016 01:57:17 +0200 Organization: LINKOV.NET Message-ID: <87h9gfus7a.fsf@mail.linkov.net> References: <87mvqel8xy.fsf@gnus.org> <83io0xrmam.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457568753 19945 80.91.229.3 (10 Mar 2016 00:12:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Mar 2016 00:12:33 +0000 (UTC) Cc: 22893@debbugs.gnu.org, larsi@gnus.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 10 01:12:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adoD6-0001N4-VV for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Mar 2016 01:12:13 +0100 Original-Received: from localhost ([::1]:45238 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adoD6-000892-Bt for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Mar 2016 19:12:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adoD1-00086b-JN for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 19:12:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adoCw-0008BH-Iv for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 19:12:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adoCw-0008Au-GE for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 19:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1adoCw-0007lw-C8 for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 19:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Mar 2016 00:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22893 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22893-submit@debbugs.gnu.org id=B22893.145756868329802 (code B ref 22893); Thu, 10 Mar 2016 00:12:02 +0000 Original-Received: (at 22893) by debbugs.gnu.org; 10 Mar 2016 00:11:23 +0000 Original-Received: from localhost ([127.0.0.1]:42068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adoCJ-0007kb-MO for submit@debbugs.gnu.org; Wed, 09 Mar 2016 19:11:23 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:46725 helo=homiemail-a15.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adoCH-0007kO-Vc; Wed, 09 Mar 2016 19:11:22 -0500 Original-Received: from homiemail-a15.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a15.g.dreamhost.com (Postfix) with ESMTP id B4E7376C06B; Wed, 9 Mar 2016 16:11:16 -0800 (PST) Original-Received: from localhost.linkov.net (62.65.227.103.cable.starman.ee [62.65.227.103]) (Authenticated sender: jurta@jurta.org) by homiemail-a15.g.dreamhost.com (Postfix) with ESMTPA id 5E30F76C069; Wed, 9 Mar 2016 16:11:15 -0800 (PST) In-Reply-To: (Tino Calancha's message of "Thu, 10 Mar 2016 00:27:35 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114680 Archived-At: merge 22893 22892 thanks > +*** New optional arg ALL-MARKS for `dired-map-over-marks' > +allow to operate over all marked files, not just those > +marked with `dired-marker-char'. > + > +*** New optional args MARKER-CHAR and ALL-MARKS for > +`dired-get-marked-files' to retrieve marked files with a > +particular mark character or with any. Since you are changing the function signatures anyway, you could make them consistent between `dired-map-over-marks' and `dired-get-marked-files' by adding an explicit arg `marker-char', i.e. both `dired-get-marked-files' and `dired-map-over-marks' could end with "distinguish-one-marked marker-char all-marks", thus explicitly passing `marker-char' arg down the call chain. Then you'll need `(or marker-char dired-marker-char)' in `dired-marker-regexp' for backward-compatibility. And then also no need to let-bind `dired-marker-char' in `dired-get-marked-files' (it's better to avoid dynamically binding global variables where possible).