From: Juri Linkov <juri@linkov.net>
To: Tino Calancha <f92capac@gmail.com>
Cc: 22893@debbugs.gnu.org, larsi@gnus.org
Subject: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Thu, 10 Mar 2016 01:57:17 +0200 [thread overview]
Message-ID: <87h9gfus7a.fsf@mail.linkov.net> (raw)
In-Reply-To: <alpine.LRH.2.20.1603100024390.17044@calancha-ilc.kek.jp> (Tino Calancha's message of "Thu, 10 Mar 2016 00:27:35 +0900 (JST)")
merge 22893 22892
thanks
> +*** New optional arg ALL-MARKS for `dired-map-over-marks'
> +allow to operate over all marked files, not just those
> +marked with `dired-marker-char'.
> +
> +*** New optional args MARKER-CHAR and ALL-MARKS for
> +`dired-get-marked-files' to retrieve marked files with a
> +particular mark character or with any.
Since you are changing the function signatures anyway,
you could make them consistent between `dired-map-over-marks'
and `dired-get-marked-files' by adding an explicit arg `marker-char',
i.e. both `dired-get-marked-files' and `dired-map-over-marks'
could end with "distinguish-one-marked marker-char all-marks",
thus explicitly passing `marker-char' arg down the call chain.
Then you'll need `(or marker-char dired-marker-char)' in
`dired-marker-regexp' for backward-compatibility. And then also
no need to let-bind `dired-marker-char' in `dired-get-marked-files'
(it's better to avoid dynamically binding global variables where possible).
next prev parent reply other threads:[~2016-03-09 23:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 9:38 bug#22893: 25.1.50; dired-get-marked-files get all marked Tino Calancha
2016-03-04 12:32 ` Lars Ingebrigtsen
2016-03-05 13:14 ` Tino Calancha
2016-03-08 5:18 ` Tino Calancha
2016-03-08 16:01 ` Eli Zaretskii
2016-03-09 15:27 ` Tino Calancha
2016-03-09 23:57 ` Juri Linkov [this message]
2016-03-10 4:19 ` Tino Calancha
2019-06-25 14:07 ` bug#22892: " Lars Ingebrigtsen
2020-08-12 11:58 ` Lars Ingebrigtsen
2016-03-10 4:43 ` Tino Calancha
2016-03-11 0:48 ` Juri Linkov
2016-03-22 9:31 ` bug#22893: dired-marker-regexp use dired-re-mark Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9gfus7a.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=22893@debbugs.gnu.org \
--cc=f92capac@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.