From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master d05806f: alas, a map can have only one parent Date: Mon, 02 May 2016 18:00:26 +0200 Message-ID: <87h9egwiud.fsf@gnus.org> References: <20160502154807.20012.10005@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462204894 19298 80.91.229.3 (2 May 2016 16:01:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 May 2016 16:01:34 +0000 (UTC) Cc: Sam Steingold To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 02 18:01:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1axGHl-00013I-Tm for ged-emacs-devel@m.gmane.org; Mon, 02 May 2016 18:01:26 +0200 Original-Received: from localhost ([::1]:37450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axGHi-0001Y6-9V for ged-emacs-devel@m.gmane.org; Mon, 02 May 2016 12:01:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axGHY-0001L9-1r for emacs-devel@gnu.org; Mon, 02 May 2016 12:01:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axGHM-0008V9-1O for emacs-devel@gnu.org; Mon, 02 May 2016 12:01:06 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:55791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axGH9-0008MW-Cp; Mon, 02 May 2016 12:00:47 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1axGGo-0005GG-9p; Mon, 02 May 2016 18:00:28 +0200 In-Reply-To: (Sam Steingold's message of "Mon, 02 May 2016 15:48:08 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203522 Archived-At: Sam Steingold writes: > alas, a map can have only one parent > > * lisp/image-mode.el (image-model-map): Cannot have two parents. > * lisp/image.el (image-map): Inherit from `special-mode-map'. This is the definition of image-mode-map: (defvar image-mode-map (let ((map (make-sparse-keymap))) ... (make-composed-keymap (list map image-map) special-mode-map)) Which should take care of the multiple inheretance. And image-map should certainly not inherit anything from special-mode-map. So I think your patch is wrong. What are you trying to fix? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no