all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Cc: Sam Steingold <sds@gnu.org>
Subject: Re: master d05806f: alas, a map can have only one parent
Date: Mon, 02 May 2016 18:00:26 +0200	[thread overview]
Message-ID: <87h9egwiud.fsf@gnus.org> (raw)
In-Reply-To: <E1axG4t-0005DO-Ve@vcs.savannah.gnu.org> (Sam Steingold's message of "Mon, 02 May 2016 15:48:08 +0000")

Sam Steingold <sds@gnu.org> writes:

>     alas, a map can have only one parent
>
>     * lisp/image-mode.el (image-model-map): Cannot have two parents.
>     * lisp/image.el (image-map): Inherit from `special-mode-map'.

This is the definition of image-mode-map:

(defvar image-mode-map
  (let ((map (make-sparse-keymap)))
  ...
    (make-composed-keymap (list map image-map) special-mode-map))

Which should take care of the multiple inheretance.

And image-map should certainly not inherit anything from
special-mode-map.

So I think your patch is wrong.  What are you trying to fix?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



       reply	other threads:[~2016-05-02 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160502154807.20012.10005@vcs.savannah.gnu.org>
     [not found] ` <E1axG4t-0005DO-Ve@vcs.savannah.gnu.org>
2016-05-02 16:00   ` Lars Ingebrigtsen [this message]
2016-05-02 16:28     ` master d05806f: alas, a map can have only one parent Sam Steingold
2016-05-02 16:32       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9egwiud.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=sds@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.