all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Chen Bin <chenbin.sh@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-mime supports emacs24
Date: Sat, 03 Sep 2016 10:41:03 +0200	[thread overview]
Message-ID: <87h99xz880.fsf@saiph.selenimh> (raw)
In-Reply-To: <874m6edi8j.fsf@gmail.com> (Chen Bin's message of "Sun, 21 Aug 2016 11:27:08 +1000")

Hello,

Chen Bin <chenbin.sh@gmail.com> writes:

> I got one patch to make org-mime.el usable at Emacs24.

Thank you. Note that I don't think "org-mime.el" has an active
maintainer anymore. If you want to get maintainership, we could as well
remove "org-mime.el" from contrib/ directory and let your repository be
the official one.

> I also clean out the obsolete code to make it not dependent on ascii
> and org export backend any more.

Why is it an issue ?

> +(eval-when-compile
> +  (require 'cl))

I suggest to (require 'cl-lib) instead and use "cl-" prefix accordingly.

>      ('semi (concat

"'semi" is probably a typo, assuming it is a `case' branch. It should be
simply "semi".

>              "--" "<<alternative>>-{\n"
>              "--" "[[text/plain]]\n" plain
> -	    (if (and images (> (length images) 0))
> -		(concat "--" "<<related>>-{\n"
> -			"--" "[[text/html]]\n"  html
> -			images
> -			"--" "}-<<related>>\n")
> -	      (concat "--" "[[text/html]]\n"  html
> -		      images))
> +	    (when images (concat "--" "<<alternative>>-{\n"))
> +            "--" "[[text/html]]\n"  html
> +	    images
> +	    (when images (concat "--" "}-<<alternative>>\n"))
>              "--" "}-<<alternative>>\n"))
>      ('vm "?")))

Ditto.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2016-09-03  8:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-21  1:27 [PATCH] org-mime supports emacs24 Chen Bin
2016-09-03  8:41 ` Nicolas Goaziou [this message]
2016-09-04  3:59   ` chen bin
2016-09-05 15:57     ` Nicolas Goaziou
2016-09-12 23:30       ` chen bin
2017-01-12 20:04         ` Kaushal Modi
2017-01-12 20:11           ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h99xz880.fsf@saiph.selenimh \
    --to=mail@nicolasgoaziou.fr \
    --cc=chenbin.sh@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.