Re: [PATCH] org-mime supports emacs24

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Chen Bin <chenbin.sh@gmail.com> writes:

> I got one patch to make org-mime.el usable at Emacs24.

Thank you. Note that I don't think "org-mime.el" has an active
maintainer anymore. If you want to get maintainership, we could as well
remove "org-mime.el" from contrib/ directory and let your repository be
the official one.

> I also clean out the obsolete code to make it not dependent on ascii
> and org export backend any more.

Why is it an issue ?

> +(eval-when-compile
> +  (require 'cl))

I suggest to (require 'cl-lib) instead and use "cl-" prefix accordingly.

>      ('semi (concat

"'semi" is probably a typo, assuming it is a `case' branch. It should be
simply "semi".

>              "--" "<<alternative>>-{\n"
>              "--" "[[text/plain]]\n" plain
> -	    (if (and images (> (length images) 0))
> -		(concat "--" "<<related>>-{\n"
> -			"--" "[[text/html]]\n"  html
> -			images
> -			"--" "}-<<related>>\n")
> -	      (concat "--" "[[text/html]]\n"  html
> -		      images))
> +	    (when images (concat "--" "<<alternative>>-{\n"))
> +            "--" "[[text/html]]\n"  html
> +	    images
> +	    (when images (concat "--" "}-<<alternative>>\n"))
>              "--" "}-<<alternative>>\n"))
>      ('vm "?")))

Ditto.


Regards,

-- 
Nicolas Goaziou