From: Adam Porter <adam@alphapapa.net>
To: emacs-orgmode@gnu.org
Subject: Re: Add org-bookmark-heading to Org proper?
Date: Thu, 22 Sep 2016 18:40:22 -0500 [thread overview]
Message-ID: <87h997zeop.fsf@alphapapa.net> (raw)
In-Reply-To: 87lgyjk9rb.fsf@nicolasgoaziou.fr
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
Hi Nicholas,
> I think Org could benefit from a shrunk version of this library, i.e.,
> `org-bookmark-make-record' and `org-bookmark-jump'.
>
> However I'm not convinced about `org-bookmark-jump-indirect' since this
> variable complicates code and the same effect can be achieved easily
> once the destination headline is reached.
>
> Besides, the helm part doesn't really belong to Org. IIUC, it is not
> even needed if we drop support for `org-bookmark-jump-indirect', as
> suggested above.
Yes, the Helm-related code would certainly be left out. I could propose
a patch to Thierry or make it a separate package on MELPA.
The indirect feature could be left out as well, but I find it so useful
that I think it might be worth including so that users can try it. It
really transforms the way I use Org, especially in combination with some
other functions I have that use indirect buffers when jumping to items
from the agenda. It wouldn't need to be enabled by default, of course.
But it's not strictly necessary, so I won't fight you on that if you
want to leave it out. ;)
> A few suggestions, after a cursory look:
>
> - please switch to lexical binding as all but one file in Org core,
>
> - it is "Org mode", not "org-mode"
>
> - `org-replace-links-in-string-with-desc' already exists, it is
> (mis)called `org-link-display-format'
>
> - `assoc' -> `assq' when key is a symbol
>
> - if you create a marker, unset it once useless
>
> - first sentence in docstrings has to fit in the first line.
Thanks for reading through the code and finding these. I'll go through
them soon and prepare a patch (which I'll post after doing the copyright
assignment).
> Thank you for your work.
No, thank you! :D
next prev parent reply other threads:[~2016-09-22 23:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 14:33 Add org-bookmark-heading to Org proper? Adam Porter
2016-09-22 15:11 ` Xebar Saram
2016-09-22 15:19 ` Kaushal Modi
2016-09-22 17:04 ` Adam Porter
2016-09-22 15:52 ` Aaron Ecay
2016-09-22 17:01 ` Adam Porter
2016-09-22 19:35 ` Nicolas Goaziou
2016-09-22 23:40 ` Adam Porter [this message]
2016-09-24 17:11 ` Nicolas Goaziou
2016-09-25 1:40 ` Adam Porter
2016-09-25 8:14 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h997zeop.fsf@alphapapa.net \
--to=adam@alphapapa.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.