From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: jca@wxcvbn.org (=?UTF-8?Q?J=C3=A9r=C3=A9mie_?= =?UTF-8?Q?Courr=C3=A8ges-Anglas?=) Newsgroups: gmane.emacs.bugs Subject: bug#24082: 25.1; vc-dir for CVS repositories list all files as if from toplevel directory Date: Sat, 08 Oct 2016 17:13:27 +0200 Message-ID: <87h98mzxew.fsf@ritchie.wxcvbn.org> References: <874m7crwv4.fsf@xi.bootis> <87twcoz08b.fsf@ritchie.wxcvbn.org> <0ad0b9e3-b4d6-b162-05fe-8800a0bb8aff@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1475939804 9364 195.159.176.226 (8 Oct 2016 15:16:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Oct 2016 15:16:44 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (berkeley-unix) To: 24082@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 08 17:16:40 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bstMG-0007lX-81 for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Oct 2016 17:16:16 +0200 Original-Received: from localhost ([::1]:41472 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bstME-0003Z0-Sc for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Oct 2016 11:16:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bstM5-0003Wv-Mu for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2016 11:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bstM2-0003pd-EF for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2016 11:16:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bstM2-0003pH-AH for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2016 11:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bstM2-0003VB-4C for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2016 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: jca@wxcvbn.org (=?UTF-8?Q?J=C3=A9r=C3=A9mie_?= =?UTF-8?Q?Courr=C3=A8ges-Anglas?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Oct 2016 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24082 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24082-submit@debbugs.gnu.org id=B24082.147593972113407 (code B ref 24082); Sat, 08 Oct 2016 15:16:02 +0000 Original-Received: (at 24082) by debbugs.gnu.org; 8 Oct 2016 15:15:21 +0000 Original-Received: from localhost ([127.0.0.1]:48863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bstLM-0003UA-M1 for submit@debbugs.gnu.org; Sat, 08 Oct 2016 11:15:20 -0400 Original-Received: from chomsky.autogeree.net ([91.216.110.36]:47351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bstLL-0003U2-4h for 24082@debbugs.gnu.org; Sat, 08 Oct 2016 11:15:19 -0400 Original-Received: from ritchie.wxcvbn.org (localhost [127.0.0.1]) by wxcvbn.org (8.15.2/8.15.2) with ESMTP id u98FDWCd038000 for <24082@debbugs.gnu.org>; Sat, 8 Oct 2016 17:13:32 +0200 (CEST) Original-Received: (from jca@localhost) by ritchie.wxcvbn.org (8.15.2/8.15.2/Submit) id u98FDVSR016230; Sat, 8 Oct 2016 17:13:31 +0200 (CEST) In-Reply-To: <0ad0b9e3-b4d6-b162-05fe-8800a0bb8aff@yandex.ru> (Dmitry Gutov's message of "Sat, 8 Oct 2016 03:38:14 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124216 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dmitry Gutov writes: > Hi! Hi, > On 07.10.2016 17:45, J=C3=A9r=C3=A9mie Courr=C3=A8ges-Anglas wrote: >> >> I see this regression using 25.1 (tarball) and emacs-26.0.50 (git). >> >> Reverting >> >> http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/vc/vc-cvs.el?id= =3Dfa7f79e8234c60ae425f7c3cf1b9486765a7111e >> >> fixes the problem here. > > I wonder how that could be possible: reverting it gives me a characterp > error. But if you mean just replacing `files' with `dir', that seems to > work, at the cost of possible performance overhead with larger > repositories. Oops, sorry. Yes indeed, I only replaced `files' with `dir'. > Could you try the more complex patch that has been posted here? You can > view it at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24082#15. > > In particular, I'd like to know whether it fixes this bug for you, It does. > and > whether it works well with all CVS repositories you work with. Works fine, there are some differences. With just `files' replaced with `dir': =2D-8<-- VC backend : CVS Working dir: /usr/ports/editors/ Repository : /cvs Module : ports/editors ./ emacs/ edited emacs/Makefile edited emacs/distinfo emacs/patches/ edited emacs/patches/patch-Makefile_in edited emacs/patches/patch-configure removed emacs/patches/patch-src_unexelf_c emacs/pkg/ edited emacs/pkg/PFRAG.no-no_x11 edited emacs/pkg/PLIST =2D->8-- With the patch in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24082#15: =2D-8<-- VC backend : CVS Working dir: /usr/ports/editors/ Repository : /cvs Module : ports/editors ./ unregistered .//emacs-wip emacs/ edited .//emacs/Makefile edited .//emacs/distinfo emacs/patches/ edited .//emacs/patches/patch-Makefile_in edited .//emacs/patches/patch-configure unregistered .//emacs/patches/patch-lisp_vc_vc-cvs_el unregistered .//emacs/patches/patch-lisp_vc_vc_el removed .//emacs/patches/patch-src_unexelf_c emacs/pkg/ edited .//emacs/pkg/PFRAG.no-no_x11 edited .//emacs/pkg/PLIST =2D->8-- So the patched version shows unregistered files and directories, which is good, but has formatting artifacts (`.//' above). Also, pressing `=3D' on `.//emacs-wip', I get the following in *Messages*: ... Traversing directory /usr/ports/editors/...done Finding changes in /usr/ports/editors/emacs-wip... vc-find-backend-function: Cannot open load file: No such file or directory,= vc-nil even though the directory contains a CVS dir, and cvs(1) works fine in it. I don't think it's a big problem though. =2D-=20 jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJX+Q0XAAoJEA36dK4VJOfuwK8QAI0uOKsO39fpk2cIHKroyk3H M0mX5PRDNe3zEYq4sHWtS5ovq7XH8jAabDrtHyIKDoXWv7sYDNE4PovFf7Dz09Mo i8/r7Oq2pimwFF+EtY+jNJQxk8cV+juu6ZzRds77ETI4EYAtBY5jIJFbYUV+YgBR V+RyVcxaE0s7KiQoK12N1l6yYvCLuDuQqR8xX/CeR0Xemp3SuG4RYMMAdeZBHTS3 zUxYJKIWTwsaBFThsgIn926s8k94/V8ekJluWX2/kwPI0PaVhO7GS/7GGA5KkzBh MQuK0dOnFGiR/p9BXKcebHHhlpJhxQ72hnVkXOEl3LvKXLrKp7iXw334HiyHom3R hrmoIORYA/465zivLbzt2OAdJO6D7F/+cFO8rkPRvo1h9i/vN07xDScbDVacFZ0d XLKja2Q/+W99qNtzVLPYP3A+Yjn2d4ai4VWRiyJoqTJVNNyqF64pLvUMgJ3nh504 DQVhob2ojw0jG6rDLxPo2Jwn/4yeNKY9hCUUzqhNqqQNLgtUaInbffML62uZwOzF ID3+Xjne5V2npZn9X8qQkiAwenFX3b6K2cM78tDIyvL0J3zta+dPfSrjO7zHV9jh 7LbgoW1ipygWFBT6/5BT1m88Ny9HOBipV1do9bEt+uoDgR8Pa01fz2yh1aMdFphh d1Y81WXsrZEAN5PvQRK0 =Hd6v -----END PGP SIGNATURE----- --=-=-=--