From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Jos=C3=A9?= L. =?UTF-8?Q?Dom=C3=A9nech?= Newsgroups: gmane.emacs.bugs Subject: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters Date: Thu, 27 Oct 2016 21:31:32 +0200 Message-ID: <87h97xpp0r.wl-domenechjosel@gmail.com> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1477600641 16454 195.159.176.226 (27 Oct 2016 20:37:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Oct 2016 20:37:21 +0000 (UTC) User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: 24620@debbugs.gnu.org, Michael Albinus To: =?UTF-8?Q?Jos=C3=A9?= L. =?UTF-8?Q?Dom=C3=A9nech?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 27 22:37:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzrQ0-0001ZE-Tu for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Oct 2016 22:36:57 +0200 Original-Received: from localhost ([::1]:44452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzrQ3-00055s-DB for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Oct 2016 16:36:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzqPG-0007ld-4i for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2016 15:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzqPC-0006io-6g for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2016 15:32:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45698) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzqPC-0006ii-4K for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2016 15:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bzqPB-0005qk-VZ for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2016 15:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jos=C3=A9?= L. =?UTF-8?Q?Dom=C3=A9nech?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2016 19:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24620 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24620-submit@debbugs.gnu.org id=B24620.147759670322461 (code B ref 24620); Thu, 27 Oct 2016 19:32:01 +0000 Original-Received: (at 24620) by debbugs.gnu.org; 27 Oct 2016 19:31:43 +0000 Original-Received: from localhost ([127.0.0.1]:32863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzqOr-0005qB-UF for submit@debbugs.gnu.org; Thu, 27 Oct 2016 15:31:42 -0400 Original-Received: from mail-wm0-f51.google.com ([74.125.82.51]:36517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzqOp-0005py-NN for 24620@debbugs.gnu.org; Thu, 27 Oct 2016 15:31:40 -0400 Original-Received: by mail-wm0-f51.google.com with SMTP id b80so54133779wme.1 for <24620@debbugs.gnu.org>; Thu, 27 Oct 2016 12:31:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:newsgroups:subject :in-reply-to:references:user-agent:mime-version; bh=24UeNzn/k2hD5P7yzFkarGHdsXjQrqzF6f2og0G2ij8=; b=lp+6vrWTj9wSyDgdK6fksN1127E49aKI0bZh1xQaBCgISkCwcTDYAoKApDrMIcFsjQ UMb/H30dcT3nazOD6aFsT43K/eKduWRp105dwRESyBHuV2WZFhg6MyIU09uluiJfveQa k24nbXuNQ3TFxgthrIHPICVzxNReXKPhetj5Ibs1e8MuXUslOLmc6pVskhkn0BO18W8O gbdh8l+HTtA+Mio9IaU3JxV8ga3P/ilYd/50WJ1s3d4CxYyDjpJ9hvlOjbdj3bcRV132 jmZdanI9KVvJb/6ScK+QOFgyXu5gp6PLA9GsmAWN1SwLoeZcf6cUBjOkuwi7d5JEOv/o F/MA== X-Gm-Message-State: ABUngvc7+iciTTziuYi5ZtzAW+nBKVj80RrSajn9EHu2n3lGAl3ysOCfghQSxVKyFprh0g== X-Received: by 10.194.201.227 with SMTP id kd3mr9909531wjc.74.1477596693978; Thu, 27 Oct 2016 12:31:33 -0700 (PDT) Original-Received: from jose-ThinkPad-Edge-E330.google.com (1.red-83-35-232.dynamicip.rima-tde.net. [83.35.232.1]) by smtp.gmail.com with ESMTPSA id r72sm4922925wmd.21.2016.10.27.12.31.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2016 12:31:33 -0700 (PDT) Original-Newsgroups: gmane.emacs.bugs In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-Mailman-Approved-At: Thu, 27 Oct 2016 16:36:46 -0400 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125080 Archived-At: On Thu, 27 Oct 2016 20:51:15 +0200, Noam Postavsky wrote: > > Does passing non-nil for the LITERAL parameter to replace-regexp-in-string help? > Yes indeed! So the patch becomes something like: diff -u /usr/local/share/emacs/26.0.50/lisp/dired-aux.orig.el /usr/local/share/emacs/26.0.50/lisp/dired-aux.el --- /usr/local/share/emacs/26.0.50/lisp/dired-aux.orig.el 2016-10-27 15:50:50.428634418 +0200 +++ /usr/local/share/emacs/26.0.50/lisp/dired-aux.el 2016-10-27 21:24:29.022566630 +0200 @@ -1013,10 +1013,13 @@ (when (zerop (dired-shell-command (replace-regexp-in-string - "%o" out-file + "%o" (shell-quote-argument out-file) (replace-regexp-in-string - "%i" (mapconcat #'file-name-nondirectory in-files " ") - (cdr rule))))) + "%i" (mapconcat (lambda (file-desc) + (shell-quote-argument + (file-name-nondirectory file-desc))) + in-files " ") + (cdr rule) nil t) nil t))) (message "Compressed %d file(s) to %s" (length in-files) (file-name-nondirectory out-file))))))) Diff finished. Thu Oct 27 21:24:43 2016