From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Date: Fri, 09 Dec 2016 17:27:45 -0800 Message-ID: <87h96cr2su.fsf@secretsauce.net> References: <874m2q1oca.fsf@gmail.com> <4707af57-53ae-9b10-686a-1ca0864b9abb@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1481333319 12173 195.159.176.226 (10 Dec 2016 01:28:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Dec 2016 01:28:39 +0000 (UTC) User-Agent: mu4e 0.9.17; emacs 26.0.50.1 Cc: emacs-devel@gnu.org, Tino Calancha To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 10 02:28:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFWSj-0001j6-AO for ged-emacs-devel@m.gmane.org; Sat, 10 Dec 2016 02:28:29 +0100 Original-Received: from localhost ([::1]:49673 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFWSm-0000TC-W2 for ged-emacs-devel@m.gmane.org; Fri, 09 Dec 2016 20:28:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFWS8-0000Mt-HW for emacs-devel@gnu.org; Fri, 09 Dec 2016 20:27:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFWS5-0000f2-Eu for emacs-devel@gnu.org; Fri, 09 Dec 2016 20:27:52 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56478) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cFWS5-0000ee-9U for emacs-devel@gnu.org; Fri, 09 Dec 2016 20:27:49 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 527FB20C46; Fri, 9 Dec 2016 20:27:47 -0500 (EST) Original-Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 09 Dec 2016 20:27:47 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=yd5y99ey8jBF8/Ir56mKzs9DsIk=; b=qgokeG LD7RrPDsiUGBLW2xA1ArZ6AWr53jbdv5p9TsA1rwKr03DBpofd8bNBveKFKNuVlY G6lfrBHEkI7U8wAsXAJ6VDmSvp1bxuGQCmPrYkIBsiKMc2I/EfZLJRbiQzKA/s4J U6t4bPeK4VN0gYMlHuYFIoSU3xRR7B2T0EM9A= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=yd5y99ey8jBF8/ Ir56mKzs9DsIk=; b=YMNgolTLZ0UEOX+aAiAWylxvSXiOsrrhx7KThcUlrvie4Y /d05nXw5/9uwVrJDOcUWyW5KaYXomw0pv+lNmh+4ye6xv0GAbpklVnGmD/mto3E2 nvwNzxP9ylk9VSm401rP+4VCW7oor9c2b8lM7k7fZ1A2tdMCUF10bgb6sDJEI= X-ME-Sender: X-Sasl-enc: 8Dk5/dKLExuLvOgS5cRIDQpsPyca7DdnqFPDQADbECVD 1481333267 Original-Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 087EC24313; Fri, 9 Dec 2016 20:27:47 -0500 (EST) Original-Received: from dima by shorty.local with local (Exim 4.87) (envelope-from ) id 1cFWS1-0005rR-HT; Fri, 09 Dec 2016 17:27:45 -0800 In-reply-to: <4707af57-53ae-9b10-686a-1ca0864b9abb@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210215 Archived-At: Hi. Dmitry Gutov writes: > I appreciate the navigation fixes, but some of these changes made > diff-auto-refine-mode work worse. In particular: > > - If there's just one hunk, I routinely pressed `n' to take advantage of > the auto-refine behavior. And point moved to the end of the hunk. > > Now, pressing `n' gives me a ding at the top of the window, then some > time passes (if the hunk is of a significant size), and auto-refine is > applied. The point doesn't move. I'm unclear about what the complaint is. Both the old and new behaviors made the auto-refinement do its thing. Is the complaint that the point no longer moves to the end (and if so, why is that "right"?) or is the "ding" the "problem? > - Another example: there are several hunks. I press `n', and the first > one doesn't get refined. It only gets refined if I press `p' to jump > back over it. OK. The logic in place is to auto-refine the hunk at point after a motion, which is why you're seeing this behavior. Are you seeing this issue only with the first hunk in a buffer and only when you first load such a buffer? If so, an auto-refinement call from a diff-mode-hook would solve this. Sounds reasonable, or are such things frowned-upon?