From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#25105: 26.0.50; diff navigation is broken Date: Thu, 05 Jan 2017 23:43:37 -0500 Message-ID: <87h95cpzly.fsf@udel.edu> References: <87inpt6lce.fsf@gmail.com> <87tw9dc7bk.fsf@secretsauce.net> <87shoxc70l.fsf@secretsauce.net> <20170106030606.GB1101@holos.localdomain> <87lguovn5f.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1483677861 23733 195.159.176.226 (6 Jan 2017 04:44:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Jan 2017 04:44:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25105@debbugs.gnu.org, Tino Calancha , Dmitry Gutov , npostavs@users.sourceforge.net To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 06 05:44:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPMNx-0004Z8-BW for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jan 2017 05:44:13 +0100 Original-Received: from localhost ([::1]:50120 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPMNw-0001hH-JR for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jan 2017 23:44:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPMNp-0001hC-Ng for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 23:44:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPMNm-00050G-Hf for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 23:44:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57075) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPMNm-00050B-CF for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 23:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPMNm-0002KV-6m for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2017 23:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2017 04:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25105-submit@debbugs.gnu.org id=B25105.14836778268925 (code B ref 25105); Fri, 06 Jan 2017 04:44:02 +0000 Original-Received: (at 25105) by debbugs.gnu.org; 6 Jan 2017 04:43:46 +0000 Original-Received: from localhost ([127.0.0.1]:44241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPMNW-0002Jt-JV for submit@debbugs.gnu.org; Thu, 05 Jan 2017 23:43:46 -0500 Original-Received: from mail-qt0-f195.google.com ([209.85.216.195]:35231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPMNV-0002Je-9Z for 25105@debbugs.gnu.org; Thu, 05 Jan 2017 23:43:45 -0500 Original-Received: by mail-qt0-f195.google.com with SMTP id f4so1681067qte.2 for <25105@debbugs.gnu.org>; Thu, 05 Jan 2017 20:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IhFxW3aris0urghwr7E3sKE1PMGw2SkO4qGb5LQyhcY=; b=s0b3MKnWbQ8BZg5KXSUA83oHjSwaG4yU3zT5TC1yuUxwcB2itfbGYlxMtQgFhMCQ// OdWKB3ycPhML+llCxcAV4asqXKI+PlRW2w8ugzbqqL/gqBuZ8I4RXsjRvsj4t27m5Psz GEyGR3DOpJeA2QgKEavqWzFkkJXGIy6cs4I2NCnATgyrItNdCkwLpKd1iqhzGqtCEQuG Zm1LiRaSSgOgGPpXK3JK2luR3V6FRRBvt18efKWTL+IUiPtT1fpfi8QX7eoxWEbH4nU/ TukXIWqo3NWdAKDEHqEx8KVodmCP+dC+d+X9ACsw7E5yrg9SOedpAQGCKjfkA6+J/2bX qs2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=IhFxW3aris0urghwr7E3sKE1PMGw2SkO4qGb5LQyhcY=; b=itiNINJGFAc5lgN5hUq9S5Sqs9KrS5Y6M6ZlEQzDoOVxMfwq1PCeGyjCyPZliXPpPg JqK/gI5pYiDueIQP1EIeDsx1XXhpJcoY6lhQT59bkvMsaj20LLEcoxU1UTKvXOfoN0DM 9j5Ti2FdrQ12weyRC8eAq8PlZBWOe64WiZX4glTnk8vkeBD6bezUZfAkTzPiP5Vu5cYQ B0K40vEqWNCV+0Nb+klXMkjxsSAOAsRnEtYj0T4UNfQOOfNFaqT/3xb80wsoljZACyux xK+7GvHLqm3ja0ERaN2WIS0XQNt0dhuAZ7xnhFwBY+XolsFrIvZmBeQx1Jrh5y7E3bdN +jDw== X-Gm-Message-State: AIkVDXKfRBUm5CseMHirUGj5RvLYqJtIYtDTGcvIGWUT3cTeenGE5lVktlJhfSLndqQL3ZQo X-Received: by 10.200.52.221 with SMTP id x29mr76661608qtb.19.1483677819575; Thu, 05 Jan 2017 20:43:39 -0800 (PST) Original-Received: from holos.localdomain (pool-173-67-40-97.bltmmd.fios.verizon.net. [173.67.40.97]) by smtp.gmail.com with ESMTPSA id c41sm31813472qtd.3.2017.01.05.20.43.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2017 20:43:38 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id A840360D63; Thu, 5 Jan 2017 23:43:37 -0500 (EST) In-Reply-To: <87lguovn5f.fsf@secretsauce.net> (Dima Kogan's message of "Thu, 05 Jan 2017 20:16:12 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127813 Archived-At: Dima Kogan writes: > Mark Oteiza writes: >> I fail to see how fixing corner cases in diff-apply-hunk has anything >> to do with diff-{file,hunk}-{next-prev} > > The issues being fixed are making anything that operates on hunks more > consistent, so diff-{file,hunk}-{next-prev} are relevant. and this entire thread is about the contention over changes specifically done to diff-{file,hunk}-{next-prev}. To quote myself: "Fixing C-c C-a to DTRT is great, thanks, but I don't think the off-by-one navigation changes to "n" and "p" (diff-hunk-next, diff-hunk-prev) make sense." https://lists.gnu.org/archive/html/emacs-devel/2016-12/msg00222.html >> At first glance, it looks like the following patch would restore the >> previous behavior, however it completely breaks auto refinement. >> >> > > If you want to restore the previous behavior, wouldn't a revert be > better? Or are you trying to restore only a subset of the previous > behavior? I did not submit it as a solution to the problem at hand. The fact that the patch breaks auto-refinement means that I cannot define my own commands to call (diff-{file-hunk}-{prev-next} ARG nil) and have it work. Put another way, your changes make it nigh impossible to get the previous n,p,{,} back without breaking something. >> With the number of actual bugs (email/format-patch/pre-diff content, >> and auto refinement) the initial patch caused, perhaps this is best. > > The email/format-patch issue has nothing to do with me; it has been a > problem for years. Yes it did, as the second recipe in this bug and 6b6abe0d clearly show. > The way to "fix" auto-refinement is to invoke > auto-refinement in a diff-mode-hook, as suggested earlier. The bug > reporter didn't like that Probably because auto-refinement is default behavior that got broken. > I'm not sure > where the pre-diff content issue came from. Likely it came up because > the patch that was in the BTS for years wasn't what ended up being > merged, so I haven't sufficiently tested it. Lesson learned. > > I consider the current behavior a significant improvement in usability, > but if there's a consensus that it's a step backward, then I'll go back > to carrying this patch in my local tree. Let me ask the few people I > know who would be using this code at all to get at least anecdotal > feedback.