From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25340: Save-some-buffers gets called when installing packages. Date: Sat, 07 Jan 2017 13:47:41 -0500 Message-ID: <87h95a3dwy.fsf@users.sourceforge.net> References: <0467624a-368b-6b61-e08d-97a34c8c25fa@gmail.com> <87zij63z0j.fsf@users.sourceforge.net> <8a717ff8-c5f7-2b3e-33d0-0a0403dbddf5@gmail.com> <87fukw5381.fsf@users.sourceforge.net> <240fc1ee-a0b8-c95b-4353-9e6bf26db940@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1483814839 21371 195.159.176.226 (7 Jan 2017 18:47:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jan 2017 18:47:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 25340@debbugs.gnu.org To: Nikolay Kudryavtsev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 07 19:47:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPw1D-00042n-Hc for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2017 19:47:07 +0100 Original-Received: from localhost ([::1]:58706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPw1H-0001Vm-L3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2017 13:47:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPw1B-0001Vh-RY for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 13:47:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPw18-0005Po-Ph for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 13:47:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59036) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPw18-0005Pk-LK for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 13:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPw18-0007me-71 for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 13:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2017 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25340 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25340-submit@debbugs.gnu.org id=B25340.148381480629899 (code B ref 25340); Sat, 07 Jan 2017 18:47:02 +0000 Original-Received: (at 25340) by debbugs.gnu.org; 7 Jan 2017 18:46:46 +0000 Original-Received: from localhost ([127.0.0.1]:46202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPw0s-0007mB-55 for submit@debbugs.gnu.org; Sat, 07 Jan 2017 13:46:46 -0500 Original-Received: from mail-io0-f178.google.com ([209.85.223.178]:36214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPw0r-0007lz-8M for 25340@debbugs.gnu.org; Sat, 07 Jan 2017 13:46:45 -0500 Original-Received: by mail-io0-f178.google.com with SMTP id j13so404427iod.3 for <25340@debbugs.gnu.org>; Sat, 07 Jan 2017 10:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yjdWYhfO3Hd6hqoTCVTKSHBipddGSXl1hFXIz8CeJGo=; b=dt2WWOyPvZZQFNbE/PnC2bi8U/QLfmrtoWY8BAmM8uBZ1AsY3WxYlXMmP51WqwTBV8 Ls/rlmEa8f9+wlx0yUNzO1RhMINfiW1rzvx6VUACWaOXyg7X19KJej1Mrfo1+vGquscA ckZrj+oQ0hjlNyiyDAzeUSEEOScRetTV2dyxuiM/ffVu7l3yDQe4s9xeWogUHnJOuDuc kwUZH+cKDMSQJ5qakAbk30D2wnfMnvo9kx9nfOJIYZpnd//249ci3G03+TtZARCpFy0x lCBtF4oqdBD+29+KDZsDy1Wy0atvyfjB+HMlC/5jUwLnlt2GYY4ktvf+dz2UKJpbdQTY L4Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=yjdWYhfO3Hd6hqoTCVTKSHBipddGSXl1hFXIz8CeJGo=; b=EVQ95w3tgFMwFbvnUv+btAsWhshRc/aafO48ayWTCCHMzXdCo/Zv/cav1wvvQstHGX rYAxCV5gwyNf3JvBZol4srl2e3rGszhDcgtIRtceTbeYDtR/I8YFY/Ecuf+s8twNNZk4 Y+XC7zGPvLgOAnaBakgKTbzO82Uu04yit+eERUnurZKYGidorp1D2yNGjpwOBiNm05w3 RPt2Bk51OTiXa3SDbdbJTtZNm1DsuHvZVb6a3qOdqvbRJAYoZ49oZftATRb/bzbivdTB vf5Lbn/fcVLotHhd8N3QC3CgJ9yY2IfXxFCK2IXEFDxeorPl16rDWMBELvoc/NAI9FkX gXMQ== X-Gm-Message-State: AIkVDXLWCM68ORn6LtwRZBOmBviZlQyLoYqYglCkJnWblyCttgjI6L9M1OISU5qY367Zug== X-Received: by 10.107.165.139 with SMTP id o133mr61504190ioe.42.1483814798619; Sat, 07 Jan 2017 10:46:38 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 197sm3515237ita.14.2017.01.07.10.46.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Jan 2017 10:46:38 -0800 (PST) In-Reply-To: <240fc1ee-a0b8-c95b-4353-9e6bf26db940@gmail.com> (Nikolay Kudryavtsev's message of "Sat, 7 Jan 2017 21:06:18 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127885 Archived-At: Nikolay Kudryavtsev writes: > I had the idea of doing this: > > (defun byte-recompile-directory (directory &optional arg force > limit-buffer-saving) > > ... > > If forth argument LIMIT-BUFFER-SAVING is 'directory, only files within > DIRECTORY would be saved. When LIMIT-BUFFER-SAVING is t no existing buffers > would be checked for modification. > > > But I found out out that having LIMIT-BUFFER-SAVING with value t like > this would not work without an accompanying change to > byte-recompile-file - since byte-recompile-file already checks whether > there's a buffer for that file and that buffer is modified. > I don't see where byte-recompile-file is checking that? > So, since I don't think that doing changes to byte-recompile-file is > the best idea, here's my current version. > > Also, note that the check in byte-recompile-file actually makes > calling save-some-buffers somewhat redundant.