all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
Cc: 25340@debbugs.gnu.org
Subject: bug#25340: Save-some-buffers gets called when installing packages.
Date: Sat, 07 Jan 2017 13:47:41 -0500	[thread overview]
Message-ID: <87h95a3dwy.fsf@users.sourceforge.net> (raw)
In-Reply-To: <240fc1ee-a0b8-c95b-4353-9e6bf26db940@gmail.com> (Nikolay Kudryavtsev's message of "Sat, 7 Jan 2017 21:06:18 +0300")

Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com> writes:

> I had the idea of doing this:
>
> (defun byte-recompile-directory (directory &optional arg force
> limit-buffer-saving)
>
> ...
>
> If forth argument LIMIT-BUFFER-SAVING is 'directory, only files within
> DIRECTORY would be saved.  When LIMIT-BUFFER-SAVING is t no existing buffers
> would be checked for modification.
>
>
> But I found out out that having LIMIT-BUFFER-SAVING with value t like
> this would not work without an accompanying change to
> byte-recompile-file - since byte-recompile-file already checks whether
> there's a buffer for that file and that buffer is modified.
>

I don't see where byte-recompile-file is checking that?

> So, since I don't think that doing changes to byte-recompile-file is
> the best idea, here's my current version.
>
> Also, note that the check in byte-recompile-file actually makes
> calling save-some-buffers somewhat redundant.







  reply	other threads:[~2017-01-07 18:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 22:42 bug#25340: Save-some-buffers gets called when installing packages Nikolay Kudryavtsev
2017-01-05  4:35 ` npostavs
2017-01-05  6:26   ` Nikolay Kudryavtsev
2017-01-06  2:31     ` npostavs
2017-01-07 18:06       ` Nikolay Kudryavtsev
2017-01-07 18:47         ` npostavs [this message]
2017-01-08  4:56           ` Nikolay Kudryavtsev
2017-01-08  5:33         ` npostavs
2017-01-08  8:06           ` Nikolay Kudryavtsev
2017-01-08 17:03             ` npostavs
     [not found]               ` <aa6168cc-d8eb-2c1c-70af-a63aed862b75@gmail.com>
2017-01-09 15:33                 ` bug#25340: Fwd: " Noam Postavsky
2017-01-16  1:09                   ` npostavs
2017-03-18  6:55                   ` Tino Calancha
2017-03-04 10:18       ` Andreas Politz
2017-03-04 14:47         ` npostavs
2017-03-04 11:25 ` Andreas Politz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h95a3dwy.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=25340@debbugs.gnu.org \
    --cc=nikolay.kudryavtsev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.