From: Tino Calancha <tino.calancha@gmail.com>
To: 25524-done@debbugs.gnu.org
Subject: bug#25524: 26.0.50; diff-mode is broken
Date: Sun, 29 Jan 2017 18:53:22 +0900 [thread overview]
Message-ID: <87h94ijip9.fsf@calancha-pc> (raw)
In-Reply-To: <87k29ie94o.fsf@gmail.com> (Tino Calancha's message of "Thu, 26 Jan 2017 13:29:59 +0900")
Tino Calancha <tino.calancha@gmail.com> writes:
> Noam Postavsky <npostavs@users.sourceforge.net> writes:
>
>> On Wed, Jan 25, 2017 at 11:32 AM, Tino Calancha <tino.calancha@gmail.com> wrote:
>>> ;; "index ", "old mode", "new mode", "new file mode" and
>>> -;; "deleted file mode" are output by git-diff.
>>> +;; "deleted file mode" are output by git-diff; "Index: " and
>>> +;; "========..." by SVN.
>>> (defconst diff-file-junk-re
>>> - "diff \\|index \\|\\(?:deleted file\\|new\\(?: file\\)?\\|old\\) mode\\|=== modified file")
>>> + (concat "Index: \\|" (make-string 67 ?=) "\\|"
>>> + "diff \\|index \\|\\(?:deleted file\\|new\\(?: file\\)?\\|old\\) mode\\|=== modified file"))
>>
>> Is it safe to assume exactly 67 "="? Maybe it would be better to use
>> something like "=\\{20,\\}", i.e. a sequence of 20 or more "=".
> Humm probably 20 is OK, but i am not using SVN in a while: i ignore if
> such '====...' might be coustomizable.
> Updated the patch to use >=20 ?=.
Pushed fix to master branch as commit 0073223c23749ffd6bd3f882bc30a82cc37efd2a
prev parent reply other threads:[~2017-01-29 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 6:42 bug#25524: 26.0.50; diff-mode is broken Dima Kogan
2017-01-25 16:32 ` Tino Calancha
2017-01-25 20:47 ` Noam Postavsky
2017-01-25 21:25 ` Dima Kogan
2017-01-26 4:29 ` Tino Calancha
2017-01-29 9:53 ` Tino Calancha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h94ijip9.fsf@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=25524-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.