From: Andrew Robbins <contact@andrewrobbins.info>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25426@debbugs.gnu.org
Subject: bug#25426: Copyright Assignment Completed
Date: Sat, 06 May 2017 07:05:03 -0400 [thread overview]
Message-ID: <87h90y5jq8.fsf@andrewrobbins.info> (raw)
In-Reply-To: <83d1bmfmpk.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2017 10:50:31 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Sat, 06 May 2017 10:16:58 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: 25426@debbugs.gnu.org
>>
>> Would people please look at the proposed patch and comment? I will
>> push to master in a few days if there are no comments.
>
> Some minor comments of my own:
> Please mention the bug number in the log message, for reference.
>
>> +(defcustom dig-program-options nil
>> + "Options for the dig program."
>> + :group 'net-utils
>> + :type '(repeat string))
>
> When you introduce new defcustoms, please provide a :version tag whose
> value is the first Emacs version where this defcustom will be
> available (26.1 in this case).
>> +(defun nslookup-host (host &optional name-server)
>> + "Look up the DNS information for HOST (name or IP address).
>> +When called interactively, DNS resolver NAME-SERVER may be specified
>> +by passing the function a prefix argument."
>
> Our standard wording for such optional behavior is like this:
>
> Look up the DNS information for HOST (name or IP address).
> Optional argument NAME-SERVER says which server to use for
> DNS resolution.
> Interactively, prompt for NAME-SERVER if invoked with prefix argument.
>
>> +(defun dns-lookup-host (host &optional name-server)
>
> Same here.
>
>> +(defun run-dig (host &optional name-server)
>
> And here.
> Finally, please add a NEWS entry to describe these new features.
>
> Thanks for working on this.
No problem--I'll have those changes made and posted back here
within the next 24 hours. If anyone else gives additional
feedback, I'll include those suggestions in the revised patch as
well.
'Til then.
next prev parent reply other threads:[~2017-05-06 11:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 14:03 bug#25426: [PATCH] in net-utils.el several DNS query functions now take optional name server argument; also, `dig-program-options' added Andrew Robbins
2017-02-14 3:15 ` bug#25426: Copyright Assignment Andrew Robbins
2017-02-14 16:23 ` Eli Zaretskii
2017-05-06 2:40 ` bug#25426: Copyright Assignment Completed Andrew Robbins
2017-05-06 7:16 ` Eli Zaretskii
2017-05-06 7:50 ` Eli Zaretskii
2017-05-06 11:05 ` Andrew Robbins [this message]
2017-05-06 12:04 ` bug#25426: [PATCH] in net-utils.el several DNS query functions now take optional name server argument; also, `dig-program-options' added npostavs
2017-05-07 8:02 ` Andrew Robbins
2017-05-07 8:36 ` bug#25426: [PATCH] 26.1; Revised patch for bug#25426 Andrew Robbins
2017-05-07 8:40 ` Andrew Robbins
2017-05-07 14:10 ` npostavs
2017-05-07 20:27 ` Andrew Robbins
2017-05-12 8:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h90y5jq8.fsf@andrewrobbins.info \
--to=contact@andrewrobbins.info \
--cc=25426@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.