Git help: what happened to nnimap-group-to-imap?

Git help: what happened to nnimap-group-to-imap?

[Nikolaus Rath]

Hello,

As of commit 5ed73 in the (now obsolete) Gnus Git repository, the
lisp/nnimap.el file had a "nnimap-group-to-imap" function.

As of emacs-25.1, the lisp/gnus/nnimap.el file in the Emacs Git
repository does not have this function.

I believe this means the function was removed at some point. So I tried
running

$ git log -50 -G "nnimap-group-to-imap" lisp/gnus 

to find the commit that removed it. But I am not getting any results.

What am I missing here?


Best,
-Nikolaus

-- 
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«

Re: Git help: what happened to nnimap-group-to-imap?

[Katsumi Yamaoka]

On Fri, 01 Sep 2017 22:27:28 +0200, Nikolaus Rath wrote:
> As of commit 5ed73 in the (now obsolete) Gnus Git repository, the
> lisp/nnimap.el file had a "nnimap-group-to-imap" function.

If you meant this change in the *Gnus git master* (I have a copy
of it locally):

commit 5ed73c72ca790ad9a18d60a89f8139c8e7769726
Author: Katsumi Yamaoka <yamaoka@jpl.org>
Date:   Thu Jul 9 03:46:27 2015 +0000

    lisp/ChangeLog, texi/ChangeLog: Fix last commit

commit 19c794d9d547fb3b3a22f28e5e4b963ff98f2f98
Author: Nikolaus Rath <Nikolaus@rath.org>
Date:   Tue Jul 7 20:52:45 2015 -0700

    nnimap.el: Handle plain value for nnimap-stream

    * lisp/nnimap.el (nnimap-open-connection-1): Always query capabilities,
      so that a 'plain value for the `nnimap-stream' server variable is
      handled correctly.
    * texi/gnus.texi: Document the 'plain option.

commit 6f138d3073523867b2a32a51d1c1c9ce572f8bc8
[...]

There is no such function `nnimap-group-to-imap' in that change
and the other two changes you seem to have made.  Hmm...

Re: Git help: what happened to nnimap-group-to-imap?

[Katsumi Yamaoka]

On Mon, 04 Sep 2017 10:19:53 +0900, Katsumi Yamaoka wrote:
> There is no such function `nnimap-group-to-imap' in that change
> and the other two changes you seem to have made.  Hmm...

I found it in the Emacs bug list but there is no trace of having
committed it: <https://debbugs.gnu.org/db/21/21057-b.html#m1>

Re: Git help: what happened to nnimap-group-to-imap?

[Nikolaus Rath]

On Sep 04 2017, Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> On Mon, 04 Sep 2017 10:19:53 +0900, Katsumi Yamaoka wrote:
>> There is no such function `nnimap-group-to-imap' in that change
>> and the other two changes you seem to have made.  Hmm...
>
> I found it in the Emacs bug list but there is no trace of having
> committed it: <https://debbugs.gnu.org/db/21/21057-b.html#m1>

Ah, thanks, silly me! I wanted to rebase this patch on Emacs master, and
missed the fact that there were two parts (and I tried to rebase only
the second).

Best,
Nikolaus


-- 
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«