From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28489: Acknowledgement (27.0.50; eieio-persistent slot type validation should be a bit smarter) Date: Wed, 27 Sep 2017 22:23:14 -0400 Message-ID: <87h8vnftnx.fsf@users.sourceforge.net> References: <87lglcn8dt.fsf@ericabrahamsen.net> <878th1i50l.fsf@ericabrahamsen.net> <87wp4lf1kq.fsf@users.sourceforge.net> <87ing4cd04.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1506565465 12586 195.159.176.226 (28 Sep 2017 02:24:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 28 Sep 2017 02:24:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: 28489@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 28 04:24:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxOUh-00026y-Sm for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Sep 2017 04:24:08 +0200 Original-Received: from localhost ([::1]:57034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxOUp-00015W-9z for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Sep 2017 22:24:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxOUf-00015D-Vo for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2017 22:24:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxOUc-0003Qn-RG for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2017 22:24:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55263) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxOUc-0003Qj-M8 for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2017 22:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxOUb-0004zf-Jr for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2017 22:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Sep 2017 02:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28489-submit@debbugs.gnu.org id=B28489.150656540419148 (code B ref 28489); Thu, 28 Sep 2017 02:24:01 +0000 Original-Received: (at 28489) by debbugs.gnu.org; 28 Sep 2017 02:23:24 +0000 Original-Received: from localhost ([127.0.0.1]:35711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxOU0-0004ym-DP for submit@debbugs.gnu.org; Wed, 27 Sep 2017 22:23:24 -0400 Original-Received: from mail-io0-f181.google.com ([209.85.223.181]:47215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxOTy-0004yY-9A for 28489@debbugs.gnu.org; Wed, 27 Sep 2017 22:23:22 -0400 Original-Received: by mail-io0-f181.google.com with SMTP id e189so372218ioa.4 for <28489@debbugs.gnu.org>; Wed, 27 Sep 2017 19:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YEIzB3EUyhtPAX4weiJxVTHF2llRqIMeubaK7Xt7gDQ=; b=adJLbYUr+n9b7AQ9xK/gvhmaZKL/clxcdTveqGdk3TYHJtVAaD+NDXdnCSHeHmeQQ5 xWr/CF3rZp1u9CPfsVC3lrIcrURSqd+qRt12qMZvSwHSYy413syZfY0CqtmwMOprl1+p BiYsqz9K4vlkQWrqin3/lf8zCTKbNsofwIaAQfF+ia3sLNCHwLEs+foUJ9iYS18dP5tO aFXKoEqtIPO6dQmvegWI/ur3Iyv4zILu2IGf+kZyauef38Caooc88ji4rXHALqqP79PO ErPsKuxOflG4uv60LPGWwwp+C4dc0R3BAuiO1Xx5NYoLiIPrwj8i6VgUzxo3V5YTrRYv Hkrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=YEIzB3EUyhtPAX4weiJxVTHF2llRqIMeubaK7Xt7gDQ=; b=tvdWtvW/S0TuQeFDu3mlYE+Kj+D839VB2cfhrf01OZgJewhMto8H0Y/k1omH/knu8q 44m0T5bUiY1JBXvUHKXHN2T9SAtNhbowq4rYPN2/jt2DKnqlh7uTcXBW2WfHAUWQa0pE 8g82XCEzwCawsKQ8M1EElfN3N4/EpygvA6LiaPIu58bKF9o/B7x6IHdpID0+NCHGrGci OLgv8STDKsRyLL6SLupVIuSKxF8OZhQwsTH/0UoH68mcI1fqJY4M0/jyFOqm2x3LZuPK 06UiAwPnUWhtM85s2HKGe3o9IRPkxSZhNTUqhxCgaex7lY7jjOSWKMbV9RmPinSWBuVf U4IA== X-Gm-Message-State: AMCzsaUAfnKhwKulRhvbQvd7cyiYxtoqIh3REebxGGrcYDUgzM0m7Qwf 3kFH4LIAtkWoPeTp0lW0isMWTw== X-Google-Smtp-Source: AOwi7QCXl6OTEUcG4lUL6IlZA8mJgh2XdYCxg0cSbP7My8t9RerJqzrOYis/MBgxX8PGK+DKzCt93w== X-Received: by 10.107.139.8 with SMTP id n8mr4791390iod.252.1506565396623; Wed, 27 Sep 2017 19:23:16 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d1sm206203ioc.29.2017.09.27.19.23.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Sep 2017 19:23:15 -0700 (PDT) In-Reply-To: <87ing4cd04.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 27 Sep 2017 09:39:07 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137528 Archived-At: Eric Abrahamsen writes: > It should be: > > (seq-filter #'eieio-persistent-slot-type-is-class-p (cdr type)) A right, that makes more sense. > This whole section of code, `eieio-persistent-validate/fix-slot-value' > and its neighbors, feels very seat-of-the-pants to me. I wish `cl-typep' > could handle more of this work. But in the meantime this patch (or > something like it) would at least address the actual bug. Hmm, to be honest I can't quite make out what this function is actually being used for. > I don't think the tabs were my fault! What's Emacs policy on this? I believe the policy is that new code should use spaces (although sometimes people ignore this, it's not a big deal), but don't touch lines just for the sake of changing the whitespace.