From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29077: 26.0; NEWS: "Values in call stack frames are now displayed using `cl-prin1'" Date: Mon, 30 Oct 2017 19:27:45 -0400 Message-ID: <87h8ugb4i6.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509406179 25662 195.159.176.226 (30 Oct 2017 23:29:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Oct 2017 23:29:39 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29077@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 31 00:28:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9JTS-0002l0-Ci for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Oct 2017 00:28:06 +0100 Original-Received: from localhost ([::1]:43017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9JTZ-0008Jp-Mn for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 19:28:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9JTT-0008JX-1i for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 19:28:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9JTO-00083u-1r for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 19:28:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34210) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9JTN-00083k-Tr for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 19:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e9JTN-0005P4-NA for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 19:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Oct 2017 23:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29077 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29077-submit@debbugs.gnu.org id=B29077.150940607520755 (code B ref 29077); Mon, 30 Oct 2017 23:28:01 +0000 Original-Received: (at 29077) by debbugs.gnu.org; 30 Oct 2017 23:27:55 +0000 Original-Received: from localhost ([127.0.0.1]:42891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9JTH-0005Oh-6N for submit@debbugs.gnu.org; Mon, 30 Oct 2017 19:27:55 -0400 Original-Received: from mail-io0-f173.google.com ([209.85.223.173]:55130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9JTE-0005OT-Ux for 29077@debbugs.gnu.org; Mon, 30 Oct 2017 19:27:53 -0400 Original-Received: by mail-io0-f173.google.com with SMTP id e89so31009995ioi.11 for <29077@debbugs.gnu.org>; Mon, 30 Oct 2017 16:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RTPYaMbuNtkz8pirE34/zIsuBG5MEGNcVayT235HSzI=; b=tRHma01WtP6S2Eh6CmRHl0AJM+tlj/Z3ceN8z3ug8hrMClPq+6s5dRmWRZODSdVBY6 UNphz+2vYVeSe+zwiKLCKNBeJ/LYnf0+RTNTI5R4xK5CoScI1RrnzFFWbzzmMq+7675y kSEoQV8Cx5EVrHL7rfPvewu7Yt1StuAQL5rKhn1/QKJiPFNsIDFlSaHnk98dxN2lOD2q tm0OaJphgGqyoaEJubIubE3S2CWDc53AAu0f6fa53xtiOV3VxZN+mlcY3uWvfWh9KKmI 48tNUJB0qEb6UdeePMJfbWmU1rGT1Iw2hRDPe7QojvUYqO4Z6uUfY4S/xyG6lh4WHsOk WaGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=RTPYaMbuNtkz8pirE34/zIsuBG5MEGNcVayT235HSzI=; b=U4ndejnCoTyY3VmLeNI+MF8dTBT8JwPWG66ruArjzVr0KIs/buCN6oU/dIzPEIwFDv TD2Axzvp5NCrq13YcssGOifaWt144EB5D1uOetYPq1gEqxiYW9uOXh0Sw9ciEK9vM8XO xWvolNnBrpxqlaKw54vavHocNvLT/ZXwjcPD46c/5BplOMyhby2MS8hGusLhCKHzRu4m inkE1BXAIXjDzENRoRbKYoch5Au15B+6j1AwO2KTnyDruxrH5ir8/AiLy2Qqcn9J/hwA VhX3seiyy1ZsecfpyPOscTS90U9Y7eIYW4TzB0F4C6sf4H9nIjntLlQZs5d80zlewy+Z Wjlw== X-Gm-Message-State: AMCzsaU7+FyeNuimovWk3dX6vlX/F++ydFCiVxnwNWhs8ZBD2jKkGS9V gj9c1LHwIm9/OGElbPxlW7fQEg== X-Google-Smtp-Source: ABhQp+SM4LGHoLFLIGBcj163JoEtwTl9l1nE18fsWYmUPgwGaw6JCPQb5OTmIhHZqZsTj97Aua58dw== X-Received: by 10.36.1.211 with SMTP id 202mr604896itk.14.1509406066987; Mon, 30 Oct 2017 16:27:46 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id s74sm202975ita.21.2017.10.30.16.27.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Oct 2017 16:27:46 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Mon, 30 Oct 2017 15:18:57 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139226 Archived-At: Drew Adams writes: > [Note: I could not send this from the Emacs 26 pretest, because of bug #29074. I'm just mailing this in.] > > 1. The NEWS entry says only this (with British spelling, BTW): The spelling was fixed in [1: def9715282]. > The old behaviour of using 'prin1' can be restored by customizing the > new option 'debugger-print-function'. > > That doesn't tell a user how to restore the old behavior. Please tell > us what print function to use to get the old behavior. Hmm, I feel that saying "The old behaviour of using 'prin1' can be restored by customizing the new option 'debugger-print-function' to 'prin1'" is obvious and redundant to the point of condescension. > The defcustom for `debugger-print-function' should offer a set of > reasonable choices, plus let you specify an arbitrary function. Those > choices should include cl-prin1 and whatever the previously used print > function was (what was it? clearly it was not `print'). Ah, I put :type 'function and :options '(cl-prin1 prin1), but apparently this doesn't actually have any effect in the customize buffer. Do you know how to fix this? > 2. Also, the function used is apparently really `cl-prin1', and there is NO doc for that function. C-h f cl-prin1 shows this: > > cl-prin1 is an autoloaded Lisp closure in `cl-print.el'. > > (cl-prin1 OBJECT &optional STREAM) > > Not documented. > > That's another bug, but please fix it as part of this report. It was fixed about a month ago [2: 8130186cfb]. > 3. Also, is the backtrace really printed using prin1 or cl-prin1? I > have print-length and print-level set to nil and print-circle set to t > or nil (neither helps). I turn off truncated lines. And yet for a > return value that is a list of 57 elements in *Backtrace* I cannot > move to the end of the list - the displayed list is truncated after a > bit. > > That's useless. Users should be able to get a full *Backtrace*, being able to move over full Lisp objects such as lists. > > I don't see this problem in previous Emacs releases. Hmm, works for me. I tried (defun return-a-long-list () (number-sequence 1 100)) M-x debug-on-entry RET return-a-long-list RET M-: (return-a-long-list) RET And I could see the whole thing just fine. > This "feature" (of cl-prin1 or whatever) has apparently not been > road-tested. Please revert it as the default behavior. Let users opt > in to use it, until you get it to work. It's generally a bad idea to > change the default behavior to some new, untested behavior. Let users > try it out for a few releases, before deciding to make it the new > default behavior. But then how would we get it road-tested by pretesters such as yourself? :) We could turn it back for 26.1 still, I guess the maintainers should make this call. [1: def9715282]: 2017-10-14 12:52:05 +0200 ; Cleanup of etc/NEWS https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=def9715282f71953740e8b92cf6443bfc459dd41 [2: 8130186cfb]: 2017-09-11 22:16:14 -0400 Add docstrings to cl-print entry points https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8130186cfb830d82e7d0cc6fb7443e3b6e026660