From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29220: 26.0.90; eieio-persistent-read fail to restore saved object. Date: Fri, 17 Nov 2017 22:40:58 -0500 Message-ID: <87h8ts1cfp.fsf@users.sourceforge.net> References: <87y3nga0lv.fsf@killashandra.ballybran.fr> <87po8s8k02.fsf@ericabrahamsen.net> <87zi7udorn.fsf@killashandra.ballybran.fr> <8760aim2a5.fsf@ericabrahamsen.net> <87375j2tzd.fsf@users.sourceforge.net> <87inecwl1v.fsf@killashandra.ballybran.fr> <87y3n81eq7.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1510976532 29777 195.159.176.226 (18 Nov 2017 03:42:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Nov 2017 03:42:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Eric Abrahamsen , 29220@debbugs.gnu.org, Stefan Monnier To: pierre.techoueyres@free.fr (Pierre =?UTF-8?Q?T=C3=A9choueyres?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 18 04:42:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFu17-0007JM-HW for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Nov 2017 04:42:05 +0100 Original-Received: from localhost ([::1]:48689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFu1D-00067S-3Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Nov 2017 22:42:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFu17-00067C-P3 for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 22:42:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFu14-0004LM-Kw for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 22:42:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36790) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eFu14-0004LC-H2 for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 22:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eFu14-0007Kf-9h for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 22:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Nov 2017 03:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29220 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29220-submit@debbugs.gnu.org id=B29220.151097646828118 (code B ref 29220); Sat, 18 Nov 2017 03:42:02 +0000 Original-Received: (at 29220) by debbugs.gnu.org; 18 Nov 2017 03:41:08 +0000 Original-Received: from localhost ([127.0.0.1]:45471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFu0C-0007JS-L9 for submit@debbugs.gnu.org; Fri, 17 Nov 2017 22:41:08 -0500 Original-Received: from mail-io0-f172.google.com ([209.85.223.172]:36250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFu0A-0007Ir-G5 for 29220@debbugs.gnu.org; Fri, 17 Nov 2017 22:41:07 -0500 Original-Received: by mail-io0-f172.google.com with SMTP id 79so3172743ioi.3 for <29220@debbugs.gnu.org>; Fri, 17 Nov 2017 19:41:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QVtz8Zb7NcIK2l0owN95VlUpC0aJGKSlHJAglhiZZao=; b=fKdPk8as16BDDgWXHSFAZ/VwmFbIfb33QfhTGIXIEcZayLV4ovqF/bgflw1FQXOL37 E5GcMdM+E8E+kIpa5mRQ5MKFnhErq3P+QxcOd9fl6D2Rk9+UvKEn/yAEzYBQ4T8/+7eO 01EW2Zrjsc83G1ffYUi9jEj6l7z+S7pKbQhThMkZ1YAgwmVOyjRi6tI5wpnBos50lsO6 Dc8QuywbXIskVkogkxd4kpr5DCe2jkYjQ0/Tq7n3XwFpEnNiM74gbycg7e1kgsrQW7kg OQ2WvZ7eI6CGUaTD9Ek8LPQtKPELjzIo+htLInojiz5U6qDgXT3o8gzpH83104Y4SVrM oSRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=QVtz8Zb7NcIK2l0owN95VlUpC0aJGKSlHJAglhiZZao=; b=L84EFPCU/jMXUYZYOT0ipEL8He1z8LpJ5AX51DTgBPMuEMw1EGfdHQNoZ1/I/xQjne ig0gCoWls7AiGED/a5AdPqcK5zbyOJd8fwkzvLos9N0rxgh8PYHIqI+bc5wJ+BHS/XY+ K16XmpRAC4L6vCQAGM3+dRpjFiWtIZGAZpOwTho5MfpATmm/INSYD7jH1s5Kl6QNOXfV 2SX5aW6nA5jSFKXXAzsazYHaq1GCNPp24fbgpvNPduTr4Cv0UNMH2i2xFkJQ+6lgKMrX hUZ0Iv184/j8/olxUoVrmmHE0glKrEreY6A7HM9/PiOE0NQ3ONFa4PtWr5c8SWpuGSNT nerg== X-Gm-Message-State: AJaThX7P6W997IyKZQkdWxip+q4GnMWfNrzMzCRPJFPLpLA6q6lIrm0j v4JSxMT3vRrmtCYopIFXui8= X-Google-Smtp-Source: AGs4zMbpn7Nx8veUFoe1dZQwbGkpzbpu2vas+02ATQM6jQCL9d70quI790OdCGGbAwH4+nl9DZEN7A== X-Received: by 10.107.181.67 with SMTP id e64mr5233100iof.211.1510976460723; Fri, 17 Nov 2017 19:41:00 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i76sm2718697ita.21.2017.11.17.19.40.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Nov 2017 19:40:59 -0800 (PST) In-Reply-To: <87y3n81eq7.fsf@users.sourceforge.net> (Noam Postavsky's message of "Tue, 14 Nov 2017 21:02:24 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140033 Archived-At: Noam Postavsky writes: > When I set a breakpoint in eieio-persistent-read, the object being seems > correct. If I evaluate (pcache-get ret 'foo) in edebug, I get 44, as > expected. But somehow the object which gets returned from > (pcache-repository :object-name #1="pcache-test/tmp2") doesn't have > anything in its hash table. Okay, I found where the problem is, it's failing pcache-validate-repo (what's the idea behind throwing an error which is caught and ignored anyway?): (cl-defmethod make-instance ((cache (subclass pcache-repository)) &rest args) ... (condition-case nil (let* ((obj (eieio-persistent-read path 'pcache-repository))) (and (or (pcache-validate-repo obj) (error "wrong version")) ... (error nil))) Specifically, this part: (defun pcache-validate-repo (cache) ... (cl-every (lambda (entry) (and (object-of-class-p entry (slot-value cache 'entry-cls)) ... (pcache-hash-table-values (slot-value cache 'entries))))) I can't really tell what this function is supposed to be checking.