From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#29405: 27.0.50; message-faces: Doc fixes and syntax touch-ups Date: Wed, 13 Dec 2017 01:04:06 +0000 Message-ID: <87h8svzbeh.fsf@gmail.com> References: <87zi7ef3ab.fsf@gmail.com> <83indq3k79.fsf@gnu.org> <83h8t91obt.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1513127115 32709 195.159.176.226 (13 Dec 2017 01:05:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 13 Dec 2017 01:05:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 29405@debbugs.gnu.org, yamaoka@jpl.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 13 02:05:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOvTy-0008Cn-CZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Dec 2017 02:05:10 +0100 Original-Received: from localhost ([::1]:33024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOvU4-0000QF-4S for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Dec 2017 20:05:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOvTx-0000O8-5T for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2017 20:05:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOvTq-0008QP-DD for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2017 20:05:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50442) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOvTq-0008Ps-8t for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2017 20:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eOvTp-000504-NN for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2017 20:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Dec 2017 01:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29405 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29405-submit@debbugs.gnu.org id=B29405.151312706319161 (code B ref 29405); Wed, 13 Dec 2017 01:05:01 +0000 Original-Received: (at 29405) by debbugs.gnu.org; 13 Dec 2017 01:04:23 +0000 Original-Received: from localhost ([127.0.0.1]:59123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOvTC-0004yy-EI for submit@debbugs.gnu.org; Tue, 12 Dec 2017 20:04:22 -0500 Original-Received: from mail-wm0-f44.google.com ([74.125.82.44]:42699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOvTA-0004yh-3G for 29405@debbugs.gnu.org; Tue, 12 Dec 2017 20:04:20 -0500 Original-Received: by mail-wm0-f44.google.com with SMTP id b199so1989423wme.1 for <29405@debbugs.gnu.org>; Tue, 12 Dec 2017 17:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=i0Zs4GtqTS8yYOyjGV+git6yWC8nN9ecLFNTtPLyenI=; b=zjWenqtdpYZy4FaewGyGQmxDAyYcTly2vmpNkwszEauAwijPi64VD7IwGNeW2lMOq2 RiGC3tek8ttofGdz74vDpD9tJoG9IM30w6N01H+1EVK6PPPX3fDVo1u5GCs9jDtemmbd IBlDrQ7mA0Sbx9eW3xLNBHhliHfd971sxNe+wfPwGasyVhKLzqy8Z5pcsCNB0ELi3yJd 7HOg28Okl3TMKdT36soA7v34QYLmzFfJIaF0Hooijq730z8nYd/aThr9AFwieOSC4OYC f1308ZWffo14L5h5YLF/GfuCzi3APbl6KZqjmVe5rtLsbdp6SMCxIgIR5sj7v/mWeFrY Ogkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=i0Zs4GtqTS8yYOyjGV+git6yWC8nN9ecLFNTtPLyenI=; b=IyGU0kwhkS8o3DhBZIfvpOW+lPjObcFexIev+3Dn7bzynB7IjQjmM6Ao3RLp98B1i1 wADP0k1ntKDlUZCt7/TNkAbeMsHBOiDMCuCyckp3UxYfayALKKvhw5tAZY1jTFiU8z2R wtCz5SqheQ+dWsB/M2A2qi4olXfiMVguZw9ypwNy9WQvv4V6Z/fLfIzEX3DpHb9gsOmp 0FtcjLnVSHMLn55ebHhLV9xXFBdE5KMmz/kWSqHzfw/ERR8MyTBjhSxnpCKXGU8S1Fu9 oBSJ0jr1Ks14tXl/XK0blPr4QFZUxrb/3d1Ln+Z1VeqMuB5oKpTLxKbwdbvDjn9A74V5 GPMw== X-Gm-Message-State: AKGB3mJCSHL+2kXJUzoJry0GwmpXYzDNScwdYSvJ02JRsoVeCZ3GANs4 dWX7jJ3DH53wKX6RqngGd/HARQ== X-Google-Smtp-Source: ACJfBott1SAX+bQR/b6PNmDJLITrbbXiaZWmuSPTg9fs6Pq0NTe+yXczkAnHmQvxDiQWoJTkSJ216w== X-Received: by 10.80.230.3 with SMTP id y3mr5306749edm.211.1513127054396; Tue, 12 Dec 2017 17:04:14 -0800 (PST) Original-Received: from localhost ([2a02:8084:4f41:8c80:9929:5bdb:4629:fab8]) by smtp.gmail.com with ESMTPSA id g20sm428423edb.75.2017.12.12.17.04.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Dec 2017 17:04:12 -0800 (PST) In-Reply-To: <83h8t91obt.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 2 Dec 2017 11:17:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141013 Archived-At: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Update-message.el-obsolete-face-aliases.patch >From eaf40bc5d1d24ba156b9ec8d11b482470396df74 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 22 Nov 2017 20:08:09 +0000 Subject: [PATCH 1/2] Update message.el obsolete face aliases * lisp/gnus/message.el: (message-header-to, message-header-cc) (message-header-subject, message-header-newsgroups) (message-header-other, message-header-name, message-header-xheader) (message-separator, message-cited-text, message-mml): Use define-obsolete-face-alias. --- lisp/gnus/message.el | 50 ++++++++++++++++++++------------------------------ 1 file changed, 20 insertions(+), 30 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index 0f99cb697d..c3aafd7c62 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -1435,9 +1435,8 @@ message-header-to (:bold t :italic t))) "Face used for displaying To headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-to-face 'face-alias 'message-header-to) -(put 'message-header-to-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-to-face + 'message-header-to "22.1") (defface message-header-cc '((((class color) @@ -1450,9 +1449,8 @@ message-header-cc (:bold t))) "Face used for displaying Cc headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-cc-face 'face-alias 'message-header-cc) -(put 'message-header-cc-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-cc-face + 'message-header-cc "22.1") (defface message-header-subject '((((class color) @@ -1465,9 +1463,8 @@ message-header-subject (:bold t))) "Face used for displaying Subject headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-subject-face 'face-alias 'message-header-subject) -(put 'message-header-subject-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-subject-face + 'message-header-subject "22.1") (defface message-header-newsgroups '((((class color) @@ -1480,9 +1477,8 @@ message-header-newsgroups (:bold t :italic t))) "Face used for displaying Newsgroups headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-newsgroups-face 'face-alias 'message-header-newsgroups) -(put 'message-header-newsgroups-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-newsgroups-face + 'message-header-newsgroups "22.1") (defface message-header-other '((((class color) @@ -1495,9 +1491,8 @@ message-header-other (:bold t :italic t))) "Face used for displaying other headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-other-face 'face-alias 'message-header-other) -(put 'message-header-other-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-other-face + 'message-header-other "22.1") (defface message-header-name '((((class color) @@ -1510,9 +1505,8 @@ message-header-name (:bold t))) "Face used for displaying header names." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-name-face 'face-alias 'message-header-name) -(put 'message-header-name-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-name-face + 'message-header-name "22.1") (defface message-header-xheader '((((class color) @@ -1525,9 +1519,8 @@ message-header-xheader (:bold t))) "Face used for displaying X-Header headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-xheader-face 'face-alias 'message-header-xheader) -(put 'message-header-xheader-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-xheader-face + 'message-header-xheader "22.1") (defface message-separator '((((class color) @@ -1540,9 +1533,8 @@ message-separator (:bold t))) "Face used for displaying the separator." :group 'message-faces) -;; backward-compatibility alias -(put 'message-separator-face 'face-alias 'message-separator) -(put 'message-separator-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-separator-face + 'message-separator "22.1") (defface message-cited-text '((((class color) @@ -1555,9 +1547,8 @@ message-cited-text (:bold t))) "Face used for displaying cited text names." :group 'message-faces) -;; backward-compatibility alias -(put 'message-cited-text-face 'face-alias 'message-cited-text) -(put 'message-cited-text-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-cited-text-face + 'message-cited-text "22.1") (defface message-mml '((((class color) @@ -1570,9 +1561,8 @@ message-mml (:bold t))) "Face used for displaying MML." :group 'message-faces) -;; backward-compatibility alias -(put 'message-mml-face 'face-alias 'message-mml) -(put 'message-mml-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-mml-face + 'message-mml "22.1") (defun message-font-lock-make-header-matcher (regexp) (let ((form -- 2.15.1 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-Modernise-message.el-face-spec-syntax.patch >From cdb6a0455bcb780a99bcf6fc3cd53ae84a216b07 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 22 Nov 2017 20:10:20 +0000 Subject: [PATCH 2/2] Modernise message.el face spec syntax * lisp/gnus/message.el (message-cited-text, message-mml): Use (DISPLAY . PLIST) face spec syntax recommended in `(elisp) Defining Faces'. --- lisp/gnus/message.el | 60 ++++++++++++++++++++++++++-------------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index c3aafd7c62..6053d33223 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -1427,12 +1427,12 @@ message-mode-syntax-table (defface message-header-to '((((class color) (background dark)) - (:foreground "DarkOliveGreen1" :bold t)) + :foreground "DarkOliveGreen1" :bold t) (((class color) (background light)) - (:foreground "MidnightBlue" :bold t)) + :foreground "MidnightBlue" :bold t) (t - (:bold t :italic t))) + :bold t :italic t)) "Face used for displaying To headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-to-face @@ -1441,12 +1441,12 @@ 'message-header-to-face (defface message-header-cc '((((class color) (background dark)) - (:foreground "chartreuse1" :bold t)) + :foreground "chartreuse1" :bold t) (((class color) (background light)) - (:foreground "MidnightBlue")) + :foreground "MidnightBlue") (t - (:bold t))) + :bold t)) "Face used for displaying Cc headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-cc-face @@ -1455,12 +1455,12 @@ 'message-header-cc-face (defface message-header-subject '((((class color) (background dark)) - (:foreground "OliveDrab1")) + :foreground "OliveDrab1") (((class color) (background light)) - (:foreground "navy blue" :bold t)) + :foreground "navy blue" :bold t) (t - (:bold t))) + :bold t)) "Face used for displaying Subject headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-subject-face @@ -1469,12 +1469,12 @@ 'message-header-subject-face (defface message-header-newsgroups '((((class color) (background dark)) - (:foreground "yellow" :bold t :italic t)) + :foreground "yellow" :bold t :italic t) (((class color) (background light)) - (:foreground "blue4" :bold t :italic t)) + :foreground "blue4" :bold t :italic t) (t - (:bold t :italic t))) + :bold t :italic t)) "Face used for displaying Newsgroups headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-newsgroups-face @@ -1483,12 +1483,12 @@ 'message-header-newsgroups-face (defface message-header-other '((((class color) (background dark)) - (:foreground "VioletRed1")) + :foreground "VioletRed1") (((class color) (background light)) - (:foreground "steel blue")) + :foreground "steel blue") (t - (:bold t :italic t))) + :bold t :italic t)) "Face used for displaying other headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-other-face @@ -1497,12 +1497,12 @@ 'message-header-other-face (defface message-header-name '((((class color) (background dark)) - (:foreground "green")) + :foreground "green") (((class color) (background light)) - (:foreground "cornflower blue")) + :foreground "cornflower blue") (t - (:bold t))) + :bold t)) "Face used for displaying header names." :group 'message-faces) (define-obsolete-face-alias 'message-header-name-face @@ -1511,12 +1511,12 @@ 'message-header-name-face (defface message-header-xheader '((((class color) (background dark)) - (:foreground "DeepSkyBlue1")) + :foreground "DeepSkyBlue1") (((class color) (background light)) - (:foreground "blue")) + :foreground "blue") (t - (:bold t))) + :bold t)) "Face used for displaying X-Header headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-xheader-face @@ -1525,12 +1525,12 @@ 'message-header-xheader-face (defface message-separator '((((class color) (background dark)) - (:foreground "LightSkyBlue1")) + :foreground "LightSkyBlue1") (((class color) (background light)) - (:foreground "brown")) + :foreground "brown") (t - (:bold t))) + :bold t)) "Face used for displaying the separator." :group 'message-faces) (define-obsolete-face-alias 'message-separator-face @@ -1539,12 +1539,12 @@ 'message-separator-face (defface message-cited-text '((((class color) (background dark)) - (:foreground "LightPink1")) + :foreground "LightPink1") (((class color) (background light)) - (:foreground "red")) + :foreground "red") (t - (:bold t))) + :bold t)) "Face used for displaying cited text names." :group 'message-faces) (define-obsolete-face-alias 'message-cited-text-face @@ -1553,12 +1553,12 @@ 'message-cited-text-face (defface message-mml '((((class color) (background dark)) - (:foreground "MediumSpringGreen")) + :foreground "MediumSpringGreen") (((class color) (background light)) - (:foreground "ForestGreen")) + :foreground "ForestGreen") (t - (:bold t))) + :bold t)) "Face used for displaying MML." :group 'message-faces) (define-obsolete-face-alias 'message-mml-face -- 2.15.1 --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Basil, could you please send log messages for the 2nd and the 3rd > patches formatted as ChangeLog entries? What is missing is the names > of functions/variables in which you make the changes, like this: > > * lisp/gnus/message.el (message-header-to, message-header-cc): Use > define-obsolete-face-alias. I don't know what got over me thinking I could get away with being lazy. > etc., I'm sure you get the idea. You can look at the other log > messages in Git, to see more examples. How do the two attached patches look? I feel as if my taste in ChangeLog authoring has a lot of room for refinement. > After you send the updated log messages, I will push these changes. Sorry about the delay on this and thank you everyone for the feedback. -- Basil --=-=-=--