From: Michael Albinus <michael.albinus@gmx.de>
To: Alan Third <alan@idiocy.org>
Cc: 29712@debbugs.gnu.org
Subject: bug#29712: 26.0.90; Three emacs-26 elisp tests are failing on darwin
Date: Sat, 16 Dec 2017 11:23:39 +0100 [thread overview]
Message-ID: <87h8srhsyc.fsf@gmx.de> (raw)
In-Reply-To: <20171216010225.GA16022@breton.holly.idiocy.org> (Alan Third's message of "Sat, 16 Dec 2017 01:02:25 +0000")
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
Alan Third <alan@idiocy.org> writes:
> This particular failure happens because echo under /bin/sh on macOS
> doesn’t recognise the -n flag:
Does the appended patch fixes this?
Best regards, Michael.
[-- Attachment #2: Type: text/plain, Size: 927 bytes --]
diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el
index c1577008d3..ff2ab31074 100644
--- a/test/lisp/net/tramp-tests.el
+++ b/test/lisp/net/tramp-tests.el
@@ -3638,7 +3638,7 @@ tramp--test-shell-command-to-string-asynchronously
"Check that two connections with separate ports are different."
(skip-unless (tramp--test-enabled))
;; Bug#29712.
- (skip-unless (not (eq system-type 'darwin)))
+ ;; (skip-unless (not (eq system-type 'darwin)))
;; We test it only for the mock-up connection; otherwise there might
;; be problems with the used ports.
(skip-unless (and (eq tramp-syntax 'default)
@@ -3663,7 +3663,7 @@ tramp--test-shell-command-to-string-asynchronously
(format "%s=%d" envvar port)
tramp-remote-process-environment)))
(should
- (string-equal
+ (string-match
(number-to-string port)
(shell-command-to-string (format "echo -n $%s" envvar))))))
next prev parent reply other threads:[~2017-12-16 10:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 16:46 bug#29712: 26.0.90; Three emacs-26 elisp tests are failing on darwin John Wiegley
2017-12-15 8:39 ` Michael Albinus
2017-12-16 1:02 ` Alan Third
2017-12-16 10:23 ` Michael Albinus [this message]
2017-12-16 13:47 ` Alan Third
2017-12-16 15:55 ` Michael Albinus
2017-12-16 1:10 ` Alan Third
2017-12-16 8:34 ` Eli Zaretskii
2017-12-16 9:46 ` Alan Third
2017-12-16 10:35 ` Eli Zaretskii
2017-12-16 13:42 ` Alan Third
2017-12-16 14:15 ` Eli Zaretskii
2017-12-16 15:07 ` Alan Third
2017-12-16 16:19 ` Eli Zaretskii
2017-12-16 16:42 ` Alan Third
2017-12-16 16:47 ` Eli Zaretskii
2017-12-16 17:01 ` Alan Third
2017-12-16 17:19 ` Eli Zaretskii
2018-01-08 21:16 ` John Wiegley
2018-01-10 0:12 ` Alan Third
2018-01-29 18:43 ` John Wiegley
2018-01-30 21:44 ` Alan Third
2018-01-30 22:40 ` John Wiegley
2018-01-31 20:03 ` Alan Third
2018-02-01 18:05 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8srhsyc.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=29712@debbugs.gnu.org \
--cc=alan@idiocy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.