From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Stream implementation of seq-mapn Date: Mon, 18 Dec 2017 13:51:02 +0100 Message-ID: <87h8sofbd5.fsf@web.de> References: <87lgi0fdt3.fsf@web.de> <87po7crzce.fsf@petton.fr> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513601438 16158 195.159.176.226 (18 Dec 2017 12:50:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Dec 2017 12:50:38 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Monnier , Emacs Development To: Nicolas Petton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 18 13:50:34 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQusL-0003eP-1o for ged-emacs-devel@m.gmane.org; Mon, 18 Dec 2017 13:50:33 +0100 Original-Received: from localhost ([::1]:59739 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQuuH-00056S-PY for ged-emacs-devel@m.gmane.org; Mon, 18 Dec 2017 07:52:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQut4-0004CU-FH for emacs-devel@gnu.org; Mon, 18 Dec 2017 07:51:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQut0-0005mL-HE for emacs-devel@gnu.org; Mon, 18 Dec 2017 07:51:18 -0500 Original-Received: from mout.web.de ([217.72.192.78]:52488) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQut0-0005kN-8J for emacs-devel@gnu.org; Mon, 18 Dec 2017 07:51:14 -0500 Original-Received: from drachen.dragon ([88.74.120.211]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M1G20-1fJpqq0vKC-00tDbw; Mon, 18 Dec 2017 13:51:04 +0100 In-Reply-To: <87po7crzce.fsf@petton.fr> (Nicolas Petton's message of "Mon, 18 Dec 2017 13:32:17 +0100") X-Provags-ID: V03:K0:w6gjFYIeImxI2C5qwJp206WmJESmeDyZMRpvCJD8KBIwEJyNKJG EEiSXJ+bCdTYUebjSxrS1tBWne3xUtdQpXYj+Py4vVd6ExIpQj0MKnzna5NLokNNCqSMLdK wpb6YW0WetewcbGl3EyDGfuCtvJBNUhqmxlwlMjyG7pUY8e8xf4Mg+978jm4bQvXQEBaXeJ cWuuFap8S9uJsfMsCtQ9g== X-UI-Out-Filterresults: notjunk:1;V01:K0:Cu3HVvCwauw=:aIIu6lmsPksj2JoJvcBIiV mfu24LojjmMco/Z/T5WHCk8EAt79kdSGSwDZQfGmkrWj3L4Xcdr0/VQC/D1KGPUY/WzMDZBL3 WE4gWX8mfFWbLRbonOfVyeummnzwlni9kPCBQcaZuL35O7R842BlIiThGWnAN7TDm/8Hz8TWE V+woWwxdrHuMrvCuaeKa3DFHYafh68Sa8+hdJ1aGInhiK7juQYKvGrprobFEQ/xjqzkgOphGW F+/sBEzNYd5syxLzhSjTjdSCITYgTUcDOFGrPXbrQvJNDA5o5xXFUFgIZBPDIlvfaslMFxopd rVzX3mnDsYXLaROwwHW9jd0hOx8GwIkK9CfWIwtypfLWGJToie2h2k0/ZIpZvflRk3bdV8Ha0 PwTL7Wb9wA7E+DZc93LZAJrP1ITEbxlHAhA6Fi/K75Wj/NMnygeIYxisZ3M2yKrkSfuErd9CV KzQGwwaeXjlhysxruwI89ZQLSFxfocy1EBBCDRH93HI+JxpROkTzdPoHangg8N/Rt1wZjVPMF bX/I0GKTafKABG3MTtmnhVnhsjBiVtsPk5n8WmA/R//e1zvhlg5qpFrtGRzI98fawviDS3NaK Y5DAVxzJ3HVf317lXNtfvWMbRAZP2CrFbLSUNJTLlYBNm/3lvWDvLioMf4mMRNbE321Pf/FSD LbMlZfmmJceSt8lYBfKrS/aB4KlNKBEBm9RbM0O/sLx97kkHQhKxzexzWE9H6RoozISnvd7HD 5eJp6dokf8pneUGCTu0qCEqSITHZ1D8PEfwJzjEigRrAwqqeKNC0Rugzi+awBP/T7he47aQV X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.72.192.78 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221215 Archived-At: Nicolas Petton writes: > > [...] > > +(cl-defmethod seq-mapn (function (stream stream) &rest streams) > > + "Map FUNCTION over the STREAMS. > I would add to the docstring that all elements of `streams' should be > streams, otherwise it will default to the generic implementation. I already had "all the STREAMS must be streams", but that looked weird. > > + (if (not (cl-every #'streamp streams)) > ^^^^^^^^ > Since this is for stream.el, why not use `seq-every-p'? > > + (cl-call-next-method) > > + (cl-callf2 cons stream streams) > > + (stream-make > > + (unless (cl-some #'seq-empty-p streams) > ^^^^^^^ > Same question :-) Ok, done. > > (1) Is it ok to implement it with `cl-call-next-method' this way? > > I guess it is. Have you tried running `seq-mapn' with a mix of streams > and lists? Sure. I does what I want: the default method is invoked. Michael.