From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 51c8369: Run secrets suite test when Emacs has dbus support Date: Fri, 06 Apr 2018 10:04:11 +0200 Message-ID: <87h8oo7ock.fsf@gmx.de> References: <20180406000306.5540.34428@vcs0.savannah.gnu.org> <20180406000308.94E77206AB@vcs0.savannah.gnu.org> <87lge07q59.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523001800 17042 195.159.176.226 (6 Apr 2018 08:03:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2018 08:03:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Emacs developers To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 06 10:03:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4ML5-0004Kl-Sk for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2018 10:03:15 +0200 Original-Received: from localhost ([::1]:34127 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4MNB-0008NS-Eq for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2018 04:05:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4MM8-0008Kz-CG for emacs-devel@gnu.org; Fri, 06 Apr 2018 04:04:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4MM3-0005gk-D5 for emacs-devel@gnu.org; Fri, 06 Apr 2018 04:04:20 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:42907) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4MM3-0005fn-45 for emacs-devel@gnu.org; Fri, 06 Apr 2018 04:04:15 -0400 Original-Received: from detlef.gmx.de ([212.86.63.48]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LjJCt-1eVZQp2uRr-00dWXN; Fri, 06 Apr 2018 10:04:12 +0200 In-Reply-To: (Tino Calancha's message of "Fri, 6 Apr 2018 16:36:08 +0900 (JST)") X-Provags-ID: V03:K1:ZIvXkp8zOw3ihov7E0cbhMRIK6tpECjOFPjb53qwOWb1Gj2RaRg 2M7y9kV0N6j57hP9gFIP2Ev/R/sU0+6YlafwmBEpAp8NiLoLESXlcJCfZFUp5SmwTh5+WYX L/C40Sx5MPPgcz3JfYWlSuCSkPn3UDqMG9GfTdxbEzaW2BB8r9c3QqGyzHNZnUZYcXg4/LP 3YHx4s+oGUtgbz753xsUA== X-UI-Out-Filterresults: notjunk:1;V01:K0:oJfmweNJsjQ=:sH6n9JeY2s6eERArFMy0AM mXax5IvwFDfbW//15Q2Ac17r756Jjli7kv+IHATC9fnQslmiBDE/mGjYco6tNq0JsXhdGWfHB SMZQculjf3SjjJv/riUx3MC4IAMWtV3/+S/4Up5GZ8o/GEnPFYhJh3tJBKbTSLuCddvCoRLzc K9lwk/8dZGNbYwUdHwCqnDsFOJcTX4jprM3UJZGj0xgZOH761v+brW6xKE+gcbKc6m/iCADjQ mnM1JdS0V+WhhibYe7OjeHATCDwK2+c+lXwOVydrJYjNh7hW6vlTgSspmDketi6dmTeKlcbsO Zp9XZlVMHa6VLPbjwaPbmzxVM2268dAAjXEW/H5EmBbUljuYj8OqcQ7MK7yKFtboMFQI1F2D4 jjBO0QSE+KnzK/fSuIGsY0+FIFgVJS1B8S4y7XS4PiYD7FGxERqIzW2XW3ZcaBPjg+pQmTwqV cuz5kywpI5Rh1kzh5/q7bNsynkkhRESGWkzNeZgDkDjR1DtaICAG9aua2xtiXcUNddmr6cc/F IbKAMEeDnM6eREg9vHflMn1wYihEg5+eYKXuJxgi8ROgaNvZ8Dy/X4Rn+4aEAqTsjh5LfsZd3 z0VSkgOfJOtxajO/bk49TwI9/TzyTFym9GVMPCBEGrCg2hphSPj4Hm8GWe39VZEcrocy+y71f DFwLlUhf+qKEMuA3I6ExyawU2BJFCkzz00ZO3Qyx0V5khZDPDwkBfnu5L+oBQemoZeAfrS9oh Xgj3ne9A6Qa6vvZmoEHUcp0Tubik7zOScCRkyVtdiqsF0YDKwHuQVs+agX+i7Cx3iPj9+Rw6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224393 Archived-At: Tino Calancha writes: Hi Tino, >> Why this? If there is no D-Bus support, secrets-enabled shall be nil, >> and the tests shall skip (except secrets-test00-availability, which >> shall fail). That's intended. > > I don't know. I saw in our gitlab CI that your new test was failing: > https://gitlab.com/emacs-ci/emacs/commits/master I see, thanks. I'll try to reproduce it locally, and fix it properly. For the future: if a test fails, pls report instead of suppressing. That's what tests are good for :-) >> FTR, this would be wrong. :expected-result must always be the first >> clause in body. > > I see. Could you please update this part? (Or anyother that you think > might be wrong). Will do. > Thanks. > Tino Best regards, Michael.