all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 51c8369: Run secrets suite test when Emacs has dbus support
Date: Fri, 06 Apr 2018 10:04:11 +0200	[thread overview]
Message-ID: <87h8oo7ock.fsf@gmx.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1804061634001.15878@calancha-pc> (Tino Calancha's message of "Fri, 6 Apr 2018 16:36:08 +0900 (JST)")

Tino Calancha <tino.calancha@gmail.com> writes:

Hi Tino,

>> Why this? If there is no D-Bus support, secrets-enabled shall be nil,
>> and the tests shall skip (except secrets-test00-availability, which
>> shall fail). That's intended.
>
> I don't know.  I saw in our gitlab CI that your new test was failing:
> https://gitlab.com/emacs-ci/emacs/commits/master

I see, thanks. I'll try to reproduce it locally, and fix it
properly. For the future: if a test fails, pls report instead of
suppressing. That's what tests are good for :-)

>> FTR, this would be wrong. :expected-result must always be the first
>> clause in body.
>
> I see.  Could you please update this part? (Or anyother that you think
> might be wrong).

Will do.

> Thanks.
> Tino

Best regards, Michael.



  reply	other threads:[~2018-04-06  8:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180406000306.5540.34428@vcs0.savannah.gnu.org>
     [not found] ` <20180406000308.94E77206AB@vcs0.savannah.gnu.org>
2018-04-06  7:25   ` master 51c8369: Run secrets suite test when Emacs has dbus support Michael Albinus
2018-04-06  7:36     ` Tino Calancha
2018-04-06  8:04       ` Michael Albinus [this message]
2018-04-06  8:20         ` Tino Calancha
2018-04-06  9:20       ` Tino Calancha
2018-04-06  9:27         ` Michael Albinus
2018-04-06  9:38           ` Tino Calancha
2018-04-06  9:52             ` Michael Albinus
2018-04-06 10:27               ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8oo7ock.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.