From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: George Kadianakis Newsgroups: gmane.emacs.bugs Subject: bug#31086: [PATCH] xref: Make xref-push-marker-stack interactive Date: Sat, 07 Apr 2018 03:05:45 +0300 Message-ID: <87h8onvq1y.fsf@riseup.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523090710 26627 195.159.176.226 (7 Apr 2018 08:45:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Apr 2018 08:45:10 +0000 (UTC) To: 31086@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 07 10:45:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4jT7-0006nf-51 for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Apr 2018 10:45:05 +0200 Original-Received: from localhost ([::1]:42077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4jVC-0007GF-QP for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Apr 2018 04:47:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4jV5-0007G3-RG for bug-gnu-emacs@gnu.org; Sat, 07 Apr 2018 04:47:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4jV0-00033P-VT for bug-gnu-emacs@gnu.org; Sat, 07 Apr 2018 04:47:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4jV0-000339-Ni for bug-gnu-emacs@gnu.org; Sat, 07 Apr 2018 04:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f4jV0-0004O1-BR for bug-gnu-emacs@gnu.org; Sat, 07 Apr 2018 04:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: George Kadianakis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Apr 2018 08:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31086 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152309081616848 (code B ref -1); Sat, 07 Apr 2018 08:47:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Apr 2018 08:46:56 +0000 Original-Received: from localhost ([127.0.0.1]:40801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4jUt-0004Nd-6n for submit@debbugs.gnu.org; Sat, 07 Apr 2018 04:46:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4bMr-0007Qo-9O for submit@debbugs.gnu.org; Fri, 06 Apr 2018 20:06:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4bMl-0004H6-5Y for submit@debbugs.gnu.org; Fri, 06 Apr 2018 20:06:00 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:45846) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f4bMl-0004Gz-1u for submit@debbugs.gnu.org; Fri, 06 Apr 2018 20:05:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4bMj-0000Vr-OW for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2018 20:05:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4bMe-0004Fd-QI for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2018 20:05:57 -0400 Original-Received: from mx1.riseup.net ([198.252.153.129]:33583) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f4bMe-0004F0-HJ for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2018 20:05:52 -0400 Original-Received: from piha.riseup.net (piha-pn.riseup.net [10.0.1.163]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id C27DB1A088C for ; Fri, 6 Apr 2018 17:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1523059550; bh=SXQFxtb8Eh5E+YI9D/iap9ctfBv0svjnEuijzLujsgw=; h=From:To:Subject:Date:From; b=Pe6mf1LrdmBxZ8nWvV2/X8PYYMbFTrHC284211havthAkFburClUZi37mDfMQJhxV oqdG7IrFx9CyOHk0F8wpOVsRUxcfoPz6xYzsrh9xBSlXVdKrm7zeVXawOMHssuL5Un /ahD77lDrnXYefELuIpwuk7ExTrVOzU+uZSej9Ko= X-Riseup-User-ID: 64807AFC411E479D02721ED155D70952CA1AB724899D11723257F5F9FA8CDEE2 Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by piha.riseup.net with ESMTPSA id AF37321DE3 for ; Fri, 6 Apr 2018 17:05:49 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Sat, 07 Apr 2018 04:46:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144962 Archived-At: Greetings emacs wizards, here is a small patch that allows xref users to push markers to the stack without using xref-find-definitions. This allows users to mark arbitrary positions in the code that they consider interesting (e.g. documentation) even tho it's not actually an xref definition. Let me know if you don't like it! :) Have a good one! --- >From 9ddda3d1724b9a40e7e9a0c413b883abc4aeab33 Mon Sep 17 00:00:00 2001 From: George Kadianakis Date: Fri, 6 Apr 2018 21:42:51 +0300 Subject: [PATCH] Make xref-push-marker-stack interactive You can now call 'xref-push-marker-stack' interactively to push the current point to the xref marker stack. This can be used to mark interesting places that you want to visit later using 'xref-pop-marker-stack'. * lisp/progmodes/xref.el (xref-push-marker-stack): Make function interactive. --- etc/NEWS | 6 ++++++ lisp/progmodes/xref.el | 7 ++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 02b31ecff4..db6122d901 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -345,6 +345,12 @@ when the PGP keyring contains a public key for every recipient. To achieve this, add 'message-add-encrypt-tag-if-can-encrypt' to 'message-send-hook'. +** Xref +++++ +*** You can now call 'xref-push-marker-stack' interactively to push +the current point to the xref marker stack. This can be used to mark +interesting places that you want to visit later using 'xref-pop-marker-stack'. + * New Modes and Packages in Emacs 27.1 +++ diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 5a9a7a925a..5c70005d13 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -352,9 +352,14 @@ xref-after-return-hook (defvar xref--marker-ring (make-ring xref-marker-ring-length) "Ring of markers to implement the marker stack.") +;;;###autoload (defun xref-push-marker-stack (&optional m) "Add point M (defaults to `point-marker') to the marker stack." - (ring-insert xref--marker-ring (or m (point-marker)))) + (interactive) + (ring-insert xref--marker-ring (or m (point-marker))) + ; If called interactively, output a message for the user + (when (called-interactively-p 'any) + (message "xref marker set for current position."))) ;;;###autoload (defun xref-pop-marker-stack () -- 2.16.2