From: Noam Postavsky <npostavs@gmail.com>
To: John Shahid <jvshahid@gmail.com>
Cc: 31793@debbugs.gnu.org, Leo Liu <sdl.web@gmail.com>
Subject: bug#31793: 26.1; (error "Lisp nesting exceeds ‘max-lisp-eval-depth’")
Date: Wed, 04 Jul 2018 18:38:40 -0400 [thread overview]
Message-ID: <87h8lelj7z.fsf@gmail.com> (raw)
In-Reply-To: <87in5wxoat.fsf@gmail.com> (John Shahid's message of "Tue, 03 Jul 2018 16:43:38 +0000")
John Shahid <jvshahid@gmail.com> writes:
>> That seems to be a result of converting `global-eldoc-mode' to use
>> `define-globalized-minor-mode' in 2349f. The recursive call seems to be
>> a result of the following sequence of calls:
>>
>> 1. python-mode is enabled which adds an eldoc-mode-hook
>> 2. eldoc-mode is turned on in the buffer triggering python's
>> eldoc-mode-hook
>> 3. python-mode hook will start an inferior process which in turn trigger
>> ,MODE-enable-in-buffers
>> 4. ,MODE-enable-in-buffers will go over the list again trying to enable
>> eldoc-mode
>>
>> The problem is in step 4. The eldoc-global-mode buffer list isn't reset
>> in step 2. Step 4 will try to enabe the mode for the same buffer and
>> start a sequence of calls at 2. I was able to fix this problem by
>> setting the buffer-list to nil inside ,MODE-enable-in-buffers. I
>> attached a patch below.
Looks good to me. I guess there is some risk since we are modifying a
macro which affects a lot of modes, but when balanced against the "risk"
that we actually fix similar problems in those modes I think this should
go to emacs-26.
> Added the bug number to the changelog entry and attached a new patch.
>
>>From 893e62ee7e3630c981adb3efa39ef409500d7657 Mon Sep 17 00:00:00 2001
> From: John Shahid <jvshahid@gmail.com>
> Date: Sat, 23 Jun 2018 11:12:44 -0400
> Subject: [PATCH] Avoid turning on the global-minor-mode recursively
> (Bug#31793)
>
> * lisp/emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Reset
> the buffer-list inside ,MODE-enable-in-buffers to avoid enabling the
> mode recursively
I would drop that comma from the commit message though, it's not really
part of the variable name, it's only meaningful in the context of a
backquote (and you forgot the period at the end of the sentence).
next prev parent reply other threads:[~2018-07-04 22:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 2:32 bug#31793: 26.1; (error "Lisp nesting exceeds ‘max-lisp-eval-depth’") Leo Liu
2018-06-12 4:43 ` Leo Liu
2018-06-12 4:59 ` Leo Liu
2018-06-12 5:21 ` Eli Zaretskii
2018-06-12 8:46 ` Leo Liu
2018-06-23 15:47 ` John Shahid
2018-06-24 8:27 ` Leo Liu
2018-06-25 13:59 ` John Shahid
2018-06-25 16:24 ` Noam Postavsky
2018-07-03 16:43 ` John Shahid
2018-07-04 22:38 ` Noam Postavsky [this message]
2018-07-05 13:59 ` Eli Zaretskii
2018-07-05 16:33 ` John Shahid
2018-07-10 12:17 ` Noam Postavsky
2018-06-12 5:04 ` Eli Zaretskii
2018-06-12 5:24 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8lelj7z.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31793@debbugs.gnu.org \
--cc=jvshahid@gmail.com \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.