all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ari Roponen <ari.roponen@gmail.com>
To: 33739@debbugs.gnu.org
Cc: Mohammad Nasirifar <far.nasiri.m@gmail.com>
Subject: bug#33739: 27.0.50; [PATCH] Harfbuzz: fix compilation with --use-cairo
Date: Fri, 14 Dec 2018 09:22:09 +0200	[thread overview]
Message-ID: <87h8fg4lpa.fsf@gmail.com> (raw)

Emacs harfbuzz-branch compiled with --with-cairo crashes because of
these lines in ftcrfont.c:

  if (ftfont_info_size != offsetof (struct ftcrfont_info, cr_font_face))
    abort ();

The following patch fixes the problem:

diff --git a/src/ftcrfont.c b/src/ftcrfont.c
index e2f84d44fc..6d74d937a7 100644
--- a/src/ftcrfont.c
+++ b/src/ftcrfont.c
@@ -41,6 +41,9 @@ struct ftcrfont_info
   bool maybe_otf;	  /* Flag to tell if this may be OTF or not.  */
   OTF *otf;
 #endif	/* HAVE_LIBOTF */
+#ifdef HAVE_HARFBUZZ
+  hb_font_t *hb_font;
+#endif  /* HAVE_HARFBUZZ */
   FT_Size ft_size;
   int index;
   FT_Matrix matrix;


In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.1, cairo version 1.16.0)
 of 2018-12-14 built on arirop
Repository revision: 0cf5d630009dfa215f488facc98c9f948eabaf2a
Repository branch: harfbuzz
Windowing system distributor 'Fedora Project', version 11.0.12003000
System Description: Fedora 29 (Twenty Nine)

Configured using:
 'configure --with-cairo'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND DBUS GSETTINGS GLIB
NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT
LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LIBSYSTEMD
JSON LCMS2 GMP





             reply	other threads:[~2018-12-14  7:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14  7:22 Ari Roponen [this message]
2018-12-14  8:54 ` bug#33739: 27.0.50; [PATCH] Harfbuzz: fix compilation with --use-cairo Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8fg4lpa.fsf@gmail.com \
    --to=ari.roponen@gmail.com \
    --cc=33739@debbugs.gnu.org \
    --cc=far.nasiri.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.