From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 00b8c7e: Make ls-lisp.el behave like Posix hosts when directory doesn't exist Date: Fri, 15 Feb 2019 16:51:57 +0100 Message-ID: <87h8d5can6.fsf@gmx.de> References: <20190215134656.1071.93029@vcs0.savannah.gnu.org> <20190215134658.0E9A3204F1@vcs0.savannah.gnu.org> <87lg2hcfc8.fsf@gmx.de> <83o97dm53f.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="181828"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 15 16:53:20 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gufnk-000lBX-OX for ged-emacs-devel@m.gmane.org; Fri, 15 Feb 2019 16:53:20 +0100 Original-Received: from localhost ([127.0.0.1]:41921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gufnj-0002va-Oz for ged-emacs-devel@m.gmane.org; Fri, 15 Feb 2019 10:53:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gufmi-0002tI-GN for emacs-devel@gnu.org; Fri, 15 Feb 2019 10:52:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gufmc-0004aT-S0 for emacs-devel@gnu.org; Fri, 15 Feb 2019 10:52:12 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:45639) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gufmT-0004Pp-KE; Fri, 15 Feb 2019 10:52:02 -0500 Original-Received: from detlef.gmx.de ([212.86.59.221]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MYg42-1gY2ay1cWY-00VTeX; Fri, 15 Feb 2019 16:51:58 +0100 In-Reply-To: <83o97dm53f.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 15 Feb 2019 17:41:40 +0200") X-Provags-ID: V03:K1:+eGo95ZX2C/KWTaC9gIbRs1D62uD8UKcnMNBBtCqq66jFskyY8K YD3hhTEW+QHMw9Nd9Uywj2wObA48V+PdS4RAVT0DWiqgUukzLnGMNwekb0wI/xMc5f7kYUM AwS6m/ahUlKScwmi9DVxK46KxJGrFau3OcrJt7O7/SaX4PIP7XjOB+PIOjlr5tIjcB2KT0b d84UGVz8RpCBMjp2koMdQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:O09QFP5TnEQ=:E2VD8BXWvtfb/rkAJOUwAw qV9OrtKuMU2v1Gf7pEKsJitQOJ5g3ntKYCq5c/FKwzP6OnB7KSgGHmFZiXBwJEkumFPzI30ay K8snAF2aQV1bh1VtrjU343R06YoriPsnlf9P3RK5AVRK0GyacQJI3i1puylouxEVyD9Lc3KTp z/aB+N9NzoFL+StTcRS4ooZ8B1ArfWWOzbC5l2RMTvQsuiqYitNWBWcsKRp0sm9J1Sg7QQVDQ r85Z7mkV225E3F8R5b9SSn9asMHTk6zCA/gFdcswCneXd4VvCrreCogL6otoG+djixXx+leV6 Gt9awc4av6kRtErtT+UWTgtPKpC1WdFwNGMj0tGjguNXty/MLr6bndjRZWOQQilX9N8nY3Oc1 q3+snnBdOF4m9AYMvXfa6W/rPr8Ll7F1d+FHQFwtFyxU4BNnT87+Bhj9jqn7A6hnYYscUd7q+ F4fMB7V3UiWCqmQ/d666SnR9wVYEDiKR0l+ctTgH6VSv1jOER8B7gi1Os8eFWtlWvaYeRv1II hAx2BS+nBNIbCwveM6jEoxMFsSxsMAj3J7MgYzwbRjUy5BzYD2pGk+MXLztycgQdzeh+BnGdC eVGQ5cJp29Q8Da5vjLLdGHw/xYSDnr04RO2dOF8ehUI3hBdRUg1zWmBqjMe0JpDvH09lR1x3t U9OqSNE4RNGqT91yCPfEga4PVHt45D1PQI/KQB1UiZP+W5xE7DOqD5pXszaeHvkAft7rdUTDp ShecpR7K8usOcY1Pfk8D1ZVtgyk0taW2nJpzUy1ycPhYpvCMcFpfj4kBmngHD6Kk7Uv2MAnP X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233381 Archived-At: Eli Zaretskii writes: Hi Eli, >> > + ;; Emulate what we do on Posix hosts when we call access-file >> > + ;; in insert-directory. >> > + (signal 'file-error >> > + (list "Reading directory" >> > + "Directory doesn't exist or is inaccessible" >> > + file)))))) >> >> On GNU/Linux, it is `file-missing' (introduced in Emacs 26). > > I know. But ls-lisp doesn't know whether it failed because the > directory doesn't exist, or does exist but isn't accessible, and > trying to discern between these two situations doesn't seem worth it. Hmm. This reminds me, that `tramp-test17-insert-directory' does not check any error condition. If I would add this, this subtle detail would count ... (Not that anybody in real life would care ...) Best regards, Michael.