From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Thu, 14 Mar 2019 22:28:24 +0100 Message-ID: <87h8c5b0xz.fsf@telefonica.net> References: <20190311104814.kp2nv6arv47hcykz@Ergus> <83y35l4ee0.fsf@gnu.org> <20190312152928.73o4b5fk4paz7wm5@Ergus> <834l883w15.fsf@gnu.org> <20190312192017.fkfd4h5gsbdue5q3@Ergus> <83imwm3fxf.fsf@gnu.org> <20190313200225.dpqrw7xthkj47fqw@Ergus> <83bm2e35a1.fsf@gnu.org> <20190314030224.l5zseslncw3xc5ox@Ergus> <835zsm2c2s.fsf@gnu.org> <20190314165147.gmtwgzqaibwbzhbm@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="57960"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 14 22:28:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4XuM-000Ezd-De for ged-emacs-devel@m.gmane.org; Thu, 14 Mar 2019 22:28:58 +0100 Original-Received: from localhost ([127.0.0.1]:45296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4XuL-0005Rs-E8 for ged-emacs-devel@m.gmane.org; Thu, 14 Mar 2019 17:28:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4XuF-0005Rc-DR for emacs-devel@gnu.org; Thu, 14 Mar 2019 17:28:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4XuD-0001Vg-PA for emacs-devel@gnu.org; Thu, 14 Mar 2019 17:28:50 -0400 Original-Received: from relayout03-redir.e.movistar.es ([86.109.101.203]:37509) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4Xtx-0001JK-Be; Thu, 14 Mar 2019 17:28:36 -0400 Original-Received: from sky (31.red-79-151-6.dynamicip.rima-tde.net [79.151.6.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 981711563@telefonica.net) by relayout03.e.movistar.es (Postfix) with ESMTPSA id 44L1zD6H4kzMlVd; Thu, 14 Mar 2019 22:28:24 +0100 (CET) In-Reply-To: <20190314165147.gmtwgzqaibwbzhbm@Ergus> (Ergus's message of "Thu, 14 Mar 2019 17:51:49 +0100") X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-TnetOut-Country: IP: 79.151.6.31 | Country: ES X-TnetOut-Information: AntiSPAM and AntiVIRUS on relayout03 X-TnetOut-MsgID: 44L1zD6H4kzMlVd.A5842 X-TnetOut-SpamCheck: no es spam, Unknown X-TnetOut-From: ofv@wanadoo.es X-TnetOut-Watermark: 1553203706.2218@LszuGYaVhJ31eeZz61898w X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.109.101.203 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234149 Archived-At: Ergus writes: > +;;;###autoload > +(define-minor-mode display-fill-column-indicator-mode > + "Toggle display fill column indicator. > +This uses `display-fill-column-indicator' internally. > + > +To change the position of the line displayed by default, > +customize `display-fill-column-indicator-column' you can change the > +character for the line setting > `display-fill-column-indicator-character'." It seems that you forgot to delete half of that docstring. > @@ -20571,14 +20687,16 @@ highlight_trailing_whitespace (struct it *it) > if (!row->reversed_p) > { > while (glyph >= start > - && glyph->type == CHAR_GLYPH > + && (glyph->type == CHAR_GLYPH > + || glyph->type == STRETCH_GLYPH) > && NILP (glyph->object)) > --glyph; > } > else > { > while (glyph <= start > - && glyph->type == CHAR_GLYPH > + && (glyph->type == CHAR_GLYPH > + || glyph->type == STRETCH_GLYPH) > && NILP (glyph->object)) > ++glyph; > } This hunk is rejected on `master'. > @@ -32645,6 +32763,9 @@ be let-bound around code that needs to disable messages temporarily. */); > /* Name of a text property which disables line-number display. */ > DEFSYM (Qdisplay_line_numbers_disable, "display-line-numbers-disable"); > > + /* Names of the face used to display fill column indicator character. */ s/Names/Name > + DEFSYM (Qfill_column, "fill-column"); > + Hmmm... is this right? Copy & pasto? > + DEFVAR_LISP ("display-fill-column-indicator-character", Vdisplay_fill_column_indicator_character, > + doc: /* Character to draw the indicator when `display-fill-column-indicator' is non-nil. > +The default is U+2502 the but a good alternative is (ascii 124) if "the but a good" > +the font in fill-column-face supports Unicode characters. */); supports -> does not support ??? This feature is highly appreciated. Thank you.