From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#34908: Push mark in xref-push-marker-stack Date: Mon, 18 Mar 2019 23:12:50 +0200 Organization: LINKOV.NET Message-ID: <87h8bz29ht.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="159355"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: =?UTF-8?Q?jo=C3=A3o_?= =?UTF-8?Q?t=C3=A1vora?= , dmitry gutov To: 34908@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 18 22:26:57 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5zmZ-000fMt-Gp for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Mar 2019 22:26:55 +0100 Original-Received: from localhost ([127.0.0.1]:47740 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5zmY-0005HA-Hi for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Mar 2019 17:26:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5zkm-0004G3-0B for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 17:25:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5zkl-0006mR-9A for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 17:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35725) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5zkk-0006m3-Ug for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 17:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h5zkk-0006Z4-Ij; Mon, 18 Mar 2019 17:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: joaotavora@gmail.com, dgutov@yandex.ru, bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Mar 2019 21:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34908 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: =?UTF-8?Q?jo=C3=A3o_?= =?UTF-8?Q?t=C3=A1vora?= , dmitry gutov Original-Received: via spool by submit@debbugs.gnu.org id=B.155294424325141 (code B ref -1); Mon, 18 Mar 2019 21:25:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Mar 2019 21:24:03 +0000 Original-Received: from localhost ([127.0.0.1]:49265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h5zjm-0006XR-V8 for submit@debbugs.gnu.org; Mon, 18 Mar 2019 17:24:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h5zjl-0006Wq-G8 for submit@debbugs.gnu.org; Mon, 18 Mar 2019 17:24:02 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35615) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5zjg-0005QZ-BC for submit@debbugs.gnu.org; Mon, 18 Mar 2019 17:23:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5zjf-0003K7-Dr for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 17:23:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5zje-0005Lz-It for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 17:23:55 -0400 Original-Received: from bonobo.maple.relay.mailchannels.net ([23.83.214.22]:58019) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5zjc-0005GC-LK for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2019 17:23:53 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 013D32C1AA6 for ; Mon, 18 Mar 2019 21:23:51 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a72.g.dreamhost.com (100-96-3-86.trex.outbound.svc.cluster.local [100.96.3.86]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B6E032C1F53 for ; Mon, 18 Mar 2019 21:23:50 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a72.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.3); Mon, 18 Mar 2019 21:23:50 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Exultant-Hysterical: 2b1f1bbd40c2e329_1552944230841_1883458773 X-MC-Loop-Signature: 1552944230841:2587704034 X-MC-Ingress-Time: 1552944230841 Original-Received: from pdx1-sub0-mail-a72.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a72.g.dreamhost.com (Postfix) with ESMTP id 68BB5806A7 for ; Mon, 18 Mar 2019 14:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=linkov.net; bh=BKfyLRYFYV3uaafaett AmKQvSPw=; b=wiytQt6o+FpZAv1PBffSX4ETRR07uggKjOSV07eKvteRYLGmhUz AF51LJ6eIcFjjqvzKmKVyCif0SgdqUrYoFUZdc+dBVtwkNbojdOm/QCs7yq5H9XH H6GNBGOxDiPlJ/P6FN0Q64pqp1mYpOVDdD9iT6w+TUlJ0qaSH08/PS9o= Original-Received: from mail.jurta.org (m91-129-106-13.cust.tele2.ee [91.129.106.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a72.g.dreamhost.com (Postfix) with ESMTPSA id 12AF58068E for ; Mon, 18 Mar 2019 14:23:43 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a72 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedutddriedugdduhedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohffkfgfgggtgfesthekredttderjeenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdeirddufeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdeirddufedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156468 Archived-At: X-Debbugs-CC: Jo=C3=A3o T=C3=A1vora , Dmitry Gutov = Shouldn't xref-push-marker-stack push the mark like all normal commands d= o? I know there is =E2=80=98M-,=E2=80=99 but why not allow using the standar= d keys =E2=80=98C-x C-SPC=E2=80=99 (pop-global-mark) and =E2=80=98C-u C-SPC=E2=80= =99 (in the same file) as well? diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 6974d00048..861e24a85f 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -365,6 +365,7 @@ xref-set-marker-ring-length =20 (defun xref-push-marker-stack (&optional m) "Add point M (defaults to `point-marker') to the marker stack." + (push-mark nil t) (ring-insert xref--marker-ring (or m (point-marker)))) =20