From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35121: [debbugs.el] debbugs-make-control-message doesn't always ask for version Date: Wed, 03 Apr 2019 09:20:30 -0400 Message-ID: <87h8bffco1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="74442"; mail-complaints-to="usenet@blaine.gmane.org" To: 35121@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 03 15:21:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBfpP-000J6a-RE for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 15:21:20 +0200 Original-Received: from localhost ([127.0.0.1]:47750 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBfpO-00015i-Mf for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 09:21:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBfpD-00012q-1M for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 09:21:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBfpB-0000mV-Rw for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 09:21:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBfp8-0000kG-FE for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 09:21:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBfp8-00068M-7Z for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 09:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Apr 2019 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155429764623536 (code B ref -1); Wed, 03 Apr 2019 13:21:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Apr 2019 13:20:46 +0000 Original-Received: from localhost ([127.0.0.1]:42192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBfor-00067W-Bm for submit@debbugs.gnu.org; Wed, 03 Apr 2019 09:20:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBfop-00067K-Vs for submit@debbugs.gnu.org; Wed, 03 Apr 2019 09:20:44 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:54405) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBfok-0000FV-Lr for submit@debbugs.gnu.org; Wed, 03 Apr 2019 09:20:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBfoj-0000Ov-Hr for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 09:20:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBfoi-00009g-DP for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 09:20:37 -0400 Original-Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:41128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBfog-0008W7-NE for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 09:20:35 -0400 Original-Received: by mail-qk1-x72f.google.com with SMTP id o129so10080876qke.8 for ; Wed, 03 Apr 2019 06:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=DSLljZ6VhSK0pDmVJ/YksLfFfP8FJpjfQaZbZgOk21U=; b=Y1cMQ5d4yk6ElfO0pJq/Q9x+xOY0qpAhGvqwt9MgNsaKw9pB8gU+uer+G1RmVJpnyP AxUrm3uBYxCWPHJkd7VnxPDzVMhJv2cZUmd/aM0cJ/KxL7VkXtRKriTPGTCE2lXBRuB2 RMyQtTbn5sFC1qqY0GgSQxmWGrLow2yMSFPRdL06aGv5niHqq8dhWOUOX9VfWemCUivj Ic4G8kPR3mK8FV/G1TebcFE/ZJCMWi39edPuVB+LtSHFf1K9oc1QDoAhvEHQJtqrhsaa LewYshd03s6zTyVoTC6TXrW5JTDnnf+hB6uFXGYZQuQCj9bdIQfSPpuMME+gdIB/QXof 8T2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=DSLljZ6VhSK0pDmVJ/YksLfFfP8FJpjfQaZbZgOk21U=; b=ODBHMLRNPoyhqMYW0ht7kSmU6hqyS0JDV9Ik/ba4T7+DgCGXYyLW/fMKzryRecDmcO Ifo2RCDcnsvIuKR/ma9IuFi5yrMY2q84Nw3QWKuc66dJrdF0qUg4bkHHmfxYLuu5si9r XYNRgKUqqq5otBabSpwl6GBjiOZRnr8sjOWwUuLU3it25h2FdkyXzx9/7bEaCToLOgHx 61EnWo8sCgbr4cTYfwA3L+aIT6Cg1xYb13w9qpSDVtCT/z3I9psTAoN7zCwoVdaGcS9K 5e6yvk3kz24zVaSX8/wdTCxy3MWUaNCGi0UPSI7KkDXBcFyAUDnU7W84B8ZGlZZ0od/r 1tkA== X-Gm-Message-State: APjAAAX+Af4n3E3jICcdyX44s2Kjky0OxmLpJmdX3k9eNyREL2c5QGgg Iz8kSILc7+yNnuCTFCXE+ibd6sUE X-Google-Smtp-Source: APXvYqxo+ouveqii1ieCA05Ef4ExdtfvXKyRVzX3T4DWEWl1YdI6a46evaQbyuvKuDVw+QwNCiKSGQ== X-Received: by 2002:a37:2c82:: with SMTP id s124mr53654462qkh.286.1554297632723; Wed, 03 Apr 2019 06:20:32 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m73sm8063592qke.95.2019.04.03.06.20.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 06:20:31 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157122 Archived-At: --=-=-= Content-Type: text/plain Severity: minor Tags: patch When using debbugs-make-control-message to make a "done" or "fixed" control message from a message-mode buffer, it doesn't ask for for a version number. That's because (debbugs-gnu-current-status) returns nil outside the *Bugs* buffer, so the (member "emacs" (cdr (assq 'package status))) check always fails. I think it should be okay to fallback to cache, or debbugs-get-status if the cache is empty, right? By the way, I wonder if we should ask for version even if the package is not Emacs (obviously the initial-input suggestion only works for Emacs), surely other packages have versions too? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Try-harder-to-debbugs-status-if-d-g-current-statu.patch Content-Description: patch >From fbaec0d15b816892c5f774ea9cfdfa6536956d8e Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 3 Apr 2019 09:03:13 -0400 Subject: [PATCH v1] Try harder to debbugs status if d-g-current-status missing * packages/debbugs/debbugs-gnu.el (debbugs-gnu-make-control-message): Fallback to debbugs-cache-data or debbugs-get-status if debbugs-gnu-current-status returns nil, otherwise we fail to ask for version number when fixing/finding/closing/etc Emacs bugs from a message-mode buffer. --- packages/debbugs/debbugs-gnu.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el index 33860c2d5..8f914d5c1 100644 --- a/packages/debbugs/debbugs-gnu.el +++ b/packages/debbugs/debbugs-gnu.el @@ -1586,7 +1586,9 @@ (defun debbugs-gnu-make-control-message (message bugid &optional reverse buffer) current-prefix-arg (when (derived-mode-p 'message-mode) (current-buffer))))) - (let* ((status (debbugs-gnu-current-status)) + (let* ((status (or (debbugs-gnu-current-status) + (gethash bugid debbugs-cache-data) + (debbugs-get-status bugid))) (version (if (and (member message '("close" "done" -- 2.11.0 --=-=-=--