From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Newsgroups: gmane.emacs.devel Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) Date: Thu, 11 Apr 2019 13:07:44 -0600 Message-ID: <87h8b4tl6n.fsf@gmail.com> References: <87wokp4okn.fsf@gmail.com> <83ef6xpo6b.fsf@gnu.org> <0f4be9a6-6e09-f55d-9f58-2a15aef264cd@cs.ucla.edu> <837ecpplw8.fsf@gnu.org> <871s2w510a.fsf@gmail.com> <922F9B91-2E9E-45F6-BB96-66CAE5E9FB81@gnu.org> <87k1goqpnn.fsf@gmail.com> <83imw8nspc.fsf@gnu.org> <87ftrcqg5j.fsf@gmail.com> <83bm20nm62.fsf@gnu.org> <87d0men4jx.fsf@gmail.com> <83o95sisk7.fsf@gnu.org> <87mulcnui4.fsf@gmail.com> <83bm1si7lf.fsf@gnu.org> <87ef6ont03.fsf@gmail.com> <83a7hci44l.fsf@gnu.org> <87a7hcndtc.fsf@gmail.com> <831s2nhza8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="98715"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 11 21:08:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEf3q-000PZf-PL for ged-emacs-devel@m.gmane.org; Thu, 11 Apr 2019 21:08:34 +0200 Original-Received: from localhost ([127.0.0.1]:53630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEf3p-00011Z-Pf for ged-emacs-devel@m.gmane.org; Thu, 11 Apr 2019 15:08:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEf38-00011I-73 for emacs-devel@gnu.org; Thu, 11 Apr 2019 15:07:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEf37-0002nk-Eh for emacs-devel@gnu.org; Thu, 11 Apr 2019 15:07:50 -0400 Original-Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:36376) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEf37-0002mw-33; Thu, 11 Apr 2019 15:07:49 -0400 Original-Received: by mail-pf1-x435.google.com with SMTP id z5so3909683pfn.3; Thu, 11 Apr 2019 12:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=B2Zf53U1SNrWykO6YIN+JAybFc+iuAvsc4y9dQjL8Y0=; b=BgcyXfWLiJ1vAt9Qx6cbCupu+dpa79KgmBFYndDQbTUbj5YIOj2lgymfeBSE56pKhn bzCXHCJCnaDEt6Tq1Jh6qC36FE4QmrmngdhtXu8CnhK2vcHwSzEkgn2oaJibTPKpVbLe 8ZMUGhjCj9aptvABNE7LNukBkWMKTk9BcdTEYfA5ILi26VRVLtNWCY+LasldkCe5ygMe yyYBjoIS+icJNinU0kWgdYeUg67ONWWaO1OQrDV4FknlZ5zbd5JLhDcxQgBxDGln5QKM /lJBgvGv9uBmar0clCppnf036/TME0wIlnwe0j/v7lYOrebhrhf6IzlKNWbBKFjgWCKR 2gng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=B2Zf53U1SNrWykO6YIN+JAybFc+iuAvsc4y9dQjL8Y0=; b=l7MiRbaMKI564NLzdkVOm9hL71+mf7oBQC7N/cyxPjgW7NV5kuMRloVPnGCXoiSSWq KZEgkb7khWdrhRcoMaM2wE8ObRKGAmMLEAe7HG4okYUa50/WDeVRluWqcoh+F6tYIXYK Vo4+vt+Xlz/sGvmW5K4b8DP0SOxLz3p/4Z/bL6HF2l8rtdVvj4JLidV8hrwcCRAHZFVr 2aFD2TDPaOvmsECtncKXgF8Fwhov2ANqXwe5ehQdDjq/bbgubMvakNp1XbFiFgHURv1l 4HICSbTQG6J7DeOgSXZqczdcfpovVyhqa46Ngbmmpe4nx2jx4L4+NGLYuxTfvulr/tyU j+Og== X-Gm-Message-State: APjAAAXEWZEn6qae80l08Njvd81ue7zWbebJ9COPEfz/YpE1gigybJTM zR9yfKTPXrEaAUlXNoAeQUWu00P0 X-Google-Smtp-Source: APXvYqzePdwHjMZMuAh59M+2R2Jj6v6WO//3DAU4qGeKGjQNIMrOJmNiryGO9C39L0UZVmYnEo8A/g== X-Received: by 2002:a63:5c43:: with SMTP id n3mr45326398pgm.163.1555009667274; Thu, 11 Apr 2019 12:07:47 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id e7sm30440613pfc.132.2019.04.11.12.07.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Apr 2019 12:07:46 -0700 (PDT) In-Reply-To: <831s2nhza8.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 31 Mar 2019 17:52:15 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::435 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235301 Archived-At: I'm back to working on this now. I have a few disjointed questions, but for now I'd like to ask: * What's your opinion on changing FRAME_WINDOW_P to basically a C version of display-graphics-p? This would move toward using multiple windowing systems simultaneously, and helps clear the intent of the predicate. I searched and only found uses of it being used as a boolean. * To get rid of a few FRAME_X_WINDOW calls in frame.c and all of the FRAME_X_OUTPUT (f)->* calls in xdisp.c I'm considering adding a new function pointer interface frame_output_interface, which would allow for a generic interface to common output_data elements. Would you be open to this? For example, the following: FRAME_X_OUTPUT (f)->nontext_cursor would be changed to something like: FRAME_OI (f)->get_nontext_cursor (f); And the FRAME_X_WINDOW calls in frame.c to: FRAME_OI (f)->have_native_window (f); * Why is the font structure within a frame's output_data instead of in the frame itself? I was considering adding it to the above interface, but I see no immediate reason why it's considered device-dependent.