From: Lars Ingebrigtsen <larsi@gnus.org>
To: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Cc: 35688@debbugs.gnu.org
Subject: bug#35688: url-auth prompt is blank when realm is the empty string
Date: Wed, 15 May 2019 06:15:03 +0200 [thread overview]
Message-ID: <87h89wxsjc.fsf@mouse.gnus.org> (raw)
In-Reply-To: <m3imugrakc.fsf@fitzsim.org> (Thomas Fitzsimmons's message of "Sat, 11 May 2019 16:38:27 -0400")
Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
> See for example:
>
> (url-retrieve-synchronously "https://outlook.office365.com/EWS/Exchange.asmx")
>
> The attached patch makes the prompt contain the full URL, and applies to
> all auth schemes. However, maybe each auth scheme should decide how to
> handle a "" realm and to fix this particular case I should just change
> url-basic-auth? I'm open to suggestions.
>
> Anyway, I'm filing this bug because I think prompting for a username and
> password while not showing the user the requested URL is a usability
> problem.
I think your fix sounds sufficient, so I've applied it to Emacs 27.1 as
is.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-05-15 4:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 20:38 bug#35688: url-auth prompt is blank when realm is the empty string Thomas Fitzsimmons
2019-05-15 4:15 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h89wxsjc.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=35688@debbugs.gnu.org \
--cc=fitzsim@fitzsim.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.