From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#36324: 27.0.50; Error in savehist-save: (wrong-type-argument listp t) Date: Sat, 22 Jun 2019 01:23:07 +0200 Message-ID: <87h88ir09w.fsf@web.de> References: <87zhma9b6v.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="215257"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: larsi@gnus.org, 36324@debbugs.gnu.org To: Davor Rotim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 22 01:24:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1heSt7-000trN-UH for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Jun 2019 01:24:10 +0200 Original-Received: from localhost ([::1]:38398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heSt6-0005r6-CO for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Jun 2019 19:24:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37725) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heSt1-0005qn-69 for bug-gnu-emacs@gnu.org; Fri, 21 Jun 2019 19:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1heSt0-0005nC-2c for bug-gnu-emacs@gnu.org; Fri, 21 Jun 2019 19:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37256) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1heSsz-0005n7-S0 for bug-gnu-emacs@gnu.org; Fri, 21 Jun 2019 19:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1heSsz-0005dL-ND for bug-gnu-emacs@gnu.org; Fri, 21 Jun 2019 19:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jun 2019 23:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36324 X-GNU-PR-Package: emacs Original-Received: via spool by 36324-submit@debbugs.gnu.org id=B36324.156115940121604 (code B ref 36324); Fri, 21 Jun 2019 23:24:01 +0000 Original-Received: (at 36324) by debbugs.gnu.org; 21 Jun 2019 23:23:21 +0000 Original-Received: from localhost ([127.0.0.1]:50800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1heSsL-0005cO-5E for submit@debbugs.gnu.org; Fri, 21 Jun 2019 19:23:21 -0400 Original-Received: from mout.web.de ([212.227.17.11]:60961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1heSsI-0005c4-Km for 36324@debbugs.gnu.org; Fri, 21 Jun 2019 19:23:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1561159388; bh=+QhaDCBhCyxOZh0bLDvJdzW32/GccUPk1ImKEOOC6I0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=iG6S7Xvg7CrO3Ehl5hcs8jJHNmLICpc1TmidSNYOTmnYh8gXRROlhAVHPLst/wAng mKvsernapCGYqw/cMI1oLfqcetdh+eQtipQQkZCsGnb/V3erIwG4kGUB3hYf0y8mFj zh83sIeCiRb78+dS2QV8uD53kvdzygkIccT0dyD4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([188.98.106.25]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0Lz376-1iiVlE0ega-014G5z; Sat, 22 Jun 2019 01:23:08 +0200 In-Reply-To: (Davor Rotim's message of "Fri, 21 Jun 2019 21:22:56 +0200") X-Provags-ID: V03:K1:+f1n918WcrW7uDQcG/xU/+vbxaeuGuPMeeOnm4D66onDKuPa7mO +Il7KEywVB8spOuieEZMlhw+SPq621SYaVOT5yC0XePZoQaXnVqgtgmcjBHtuTsbm32sHOu DS/B0Mwea3lPhiF8JyRnEdJ6Y29IgMWrBnJkItveM8BQA3GbU3VEjkLZcCrg0IuUxoudIXX MWqkqXFJBEDGCIcl/ff+Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:tM5dJSGhyPY=:QWKG+VVkYElK48PP5Rry7e KXLw3DPC1c2d1Q/yjnPiWoQ1VpezWlynTJTKXSyZHIZeiAseufAhl2gWyQahK76btMJcLUdoo cz0Z2JzqaUGZbnVbF00ziGji3KDunOsYq6urU8S+mWFMAICbQ/S3L3QLrGZQx6iMquNZVE3KU /vuVgD1ARM5RG/AfmfiOicaw3vLrKEPs4+X7wnO9XtSCy9HhWjlDwJQWMxGaJ7VWuvpVrVAw+ eJ6yyCZt47UEZnDk37DSh5cntiOypM+hYl7cqyOdAPwxQiH26nA/rF5xEjVeUq+psvDKa5Nk/ Yew4/VNQ0E1oQpW4EV1GXv7cWs/O1hcF1hpALlpUt98Tec0frbNByRLDzi1cEcoz6xqo0fNJq UeKNNu/g2DyWDq9UXfFnOCA6s4d/FsODB0Hn1pU1kop7be9o9O2c+XRofmtiohbEYJGPs4QaV B+5/z+Z7ZOC1vSmEJj0vG29+1kAJyF4pvn4o5lAanrRMGVcOKBllwGdL8WWoozYlpuwHF1kzJ hT2iaV/ignQzCB0EO0axhlgLYV4LHRXtCRfESrE/R6R8D/Dv/JcSN6+pPDHTGRsWNb909Rzy9 HEM6s/x/8qAqzAutcAAZ2xOk2NDvP4rbKlQ8MQ4T++YGkLk5PEOdncZsTu+vOjI2Q0BtShTbX tCSbdyDfXn1gwvEwldyMlc1ACbJQpNbguYzHDaqp6UJ3DI+XU2LU90khALR5lbp3AEEVSMsVr 4lBBUIGbEJdtQYQM4ZKbOksL3srdffxIalXr8tqqzq5jfyqCDfUZ7a6UrGDJ7zl2Cgx9Dd4H X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160960 Archived-At: Davor Rotim writes: > read-string("Confirm password: " nil t nil) > read-passwd("Confirm password: " nil nil) Ah - AFAIU this binds `minibuffer-history-variable' to t in the minibuffer. So this part of Lars' commit: - (unless (or (eq minibuffer-history-variable t) - ;; XEmacs sets minibuffer-history-variable to t to mean "no - ;; history is being recorded". - (memq minibuffer-history-variable savehist-ignored-variables)) + (unless (memq minibuffer-history-variable savehist-ignored-variables) is the culprit. We should only update the comment since Gnu Emacs is doing this as well. Lars, if you agree, could you please do this? Thanks, Michael.