all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Davor Rotim <rotim.davor@gmail.com>
Cc: larsi@gnus.org, 36324@debbugs.gnu.org
Subject: bug#36324: 27.0.50; Error in savehist-save: (wrong-type-argument listp t)
Date: Sat, 22 Jun 2019 01:23:07 +0200	[thread overview]
Message-ID: <87h88ir09w.fsf@web.de> (raw)
In-Reply-To: <CAMWA6ANQCWROKepbAKdXJg1NqpVhj9pX2B56ChTCqdyz4s0umg@mail.gmail.com> (Davor Rotim's message of "Fri, 21 Jun 2019 21:22:56 +0200")

Davor Rotim <rotim.davor@gmail.com> writes:

>   read-string("Confirm password: " nil t nil)
>   read-passwd("Confirm password: " nil nil)

Ah - AFAIU this binds `minibuffer-history-variable' to t in the
minibuffer.

So this part of Lars' commit:

-  (unless (or (eq minibuffer-history-variable t)
-	      ;; XEmacs sets minibuffer-history-variable to t to mean "no
-	      ;; history is being recorded".
-	      (memq minibuffer-history-variable savehist-ignored-variables))
+  (unless (memq minibuffer-history-variable savehist-ignored-variables)

is the culprit.  We should only update the comment since Gnu Emacs is
doing this as well.

Lars, if you agree, could you please do this?

Thanks,

Michael.





  reply	other threads:[~2019-06-21 23:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 16:04 bug#36324: 27.0.50; Error in savehist-save: (wrong-type-argument listp t) Michael Heerdegen
2019-06-21 16:16 ` Lars Ingebrigtsen
2019-06-21 16:40   ` Michael Heerdegen
2019-06-21 16:50     ` Lars Ingebrigtsen
2019-06-21 17:05       ` Michael Heerdegen
2019-06-21 19:22 ` Davor Rotim
2019-06-21 23:23   ` Michael Heerdegen [this message]
2019-06-22  2:35     ` Michael Heerdegen
2019-06-22  9:33       ` Lars Ingebrigtsen
2019-06-22 15:29         ` Michael Heerdegen
2019-06-22 17:41           ` Noam Postavsky
2019-06-22 17:51             ` Michael Heerdegen
2019-06-23 12:01           ` Lars Ingebrigtsen
2019-06-23 15:27             ` Michael Heerdegen
2019-06-22  9:20     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h88ir09w.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=36324@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=rotim.davor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.