From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 783eca5: Make describe-face also output the version information Date: Mon, 15 Jul 2019 18:01:10 +0200 Message-ID: <87h87ncmnt.fsf@mouse.gnus.org> References: <20190714165035.21690.67881@vcs0.savannah.gnu.org> <20190714165036.218A32088F@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="267295"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 15 18:01:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hn3Q7-0017Qi-Ls for ged-emacs-devel@m.gmane.org; Mon, 15 Jul 2019 18:01:43 +0200 Original-Received: from localhost ([::1]:40498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn3Q6-0003Fk-D6 for ged-emacs-devel@m.gmane.org; Mon, 15 Jul 2019 12:01:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55549) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn3Pk-0002zV-BX for emacs-devel@gnu.org; Mon, 15 Jul 2019 12:01:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hn3Pi-0004zN-5D for emacs-devel@gnu.org; Mon, 15 Jul 2019 12:01:20 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:39214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hn3Ph-0004ya-Ud for emacs-devel@gnu.org; Mon, 15 Jul 2019 12:01:18 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hn3Pb-0000nM-5U; Mon, 15 Jul 2019 18:01:13 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 15 Jul 2019 09:20:47 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238600 Archived-At: Stefan Monnier writes: >> - (terpri))))))) >> + (terpri) >> + (let ((version-info (describe-variable-custom-version-info >> + f 'face))) >> + (when version-info >> + (insert version-info) >> + (terpri))))))))) > > Any chance you could do it like I did for vars and functions (i.e. via > a help-fns-describe-face-functions)? Sure; looks easy enough. I think I'll report this as a separate bug, though, since I probably won't have time the next few days. By the way, looking over the new infrastructure, perhaps these two bits should be separated out into separate functions for help-fns-describe-variable-functions? They're currently in describe-variable: ;; Make a link to customize if this variable can be customized. (when (custom-variable-p variable) (let ((customize-label "customize")) (terpri) (terpri) (princ (concat "You can " customize-label " this variable.")) (with-current-buffer standard-output (save-excursion (re-search-backward (concat "\\(" customize-label "\\)") nil t) (help-xref-button 1 'help-customize-variable variable)))) ;; Note variable's version or package version. (let ((output (describe-variable-custom-version-info variable))) (when output (terpri) (terpri) (princ output)))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no