From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11944: 24.1.50; newcomment needs comment-normalize-vars in more functions Date: Sat, 17 Aug 2019 14:50:03 -0700 Message-ID: <87h86flawk.fsf@mouse.gnus.org> References: <87fw8txj8e.fsf@sc3d.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="96310"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 11944@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 17 23:51:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hz6bO-000OqE-Md for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Aug 2019 23:51:10 +0200 Original-Received: from localhost ([::1]:38224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hz6bN-0001zQ-LZ for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Aug 2019 17:51:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42158) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hz6bH-0001zB-GH for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2019 17:51:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hz6bG-0001qM-D9 for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2019 17:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48150) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hz6bG-0001qG-9S for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2019 17:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hz6bG-0004rF-5z for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2019 17:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Aug 2019 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11944 X-GNU-PR-Package: emacs Original-Received: via spool by 11944-submit@debbugs.gnu.org id=B11944.156607861218601 (code B ref 11944); Sat, 17 Aug 2019 21:51:02 +0000 Original-Received: (at 11944) by debbugs.gnu.org; 17 Aug 2019 21:50:12 +0000 Original-Received: from localhost ([127.0.0.1]:56968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hz6aR-0004pw-Lb for submit@debbugs.gnu.org; Sat, 17 Aug 2019 17:50:11 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:55936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hz6aQ-0004pj-5i for 11944@debbugs.gnu.org; Sat, 17 Aug 2019 17:50:10 -0400 Original-Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hz6aL-0004GK-I2; Sat, 17 Aug 2019 23:50:08 +0200 In-Reply-To: <87fw8txj8e.fsf@sc3d.org> (Reuben Thomas's message of "Sun, 15 Jul 2012 14:10:57 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165288 Archived-At: Reuben Thomas writes: > When adding a word to a per-buffer dictionary in an AuCTeX buffer, I get > an error caused by the fact that AuCTeX sets comment-padding to 1, then > calls comment-padright, which assumes comment-padding is a string. > > A similar bug report is here: > > http://lists.gnu.org/archive/html/bug-auctex/2011-12/msg00000.html > > Making comment-padright call comment-normalize-vars fixes this problem; > presumably at least comment-padleft and perhaps other functions need the > same treatment. > > (As far as I can see, setting comment-padding to an integer is still > allowed, as per its docstring.) (I'm going through old bug reports that have unfortunately gotten no responses yet.) The doc in newcomment.el specifies that any command that calls the newcomment functions should call `comment-normalize-vars' first, so I don't think this is a bug in newcomment.el. (All the commands in that file do this.) So this sounds like a bug in AuCTeX. Are you still seeing this bug, and if so, do you have a backtrace that'll show where AuCTeX is bugging out? The referenced URL is just somebody calling `commend-padright' directly, which isn't allowed. (I'll add that to the doc string of that function.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no