all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Katsumi Yamaoka <yamaoka@jpl.org>,
	"Jose A. Ortega Ruiz" <jao@gnu.org>,
	37515@debbugs.gnu.org
Subject: bug#37515: 27.0.50; button.el doesn't support help-echo function
Date: Fri, 04 Oct 2019 00:00:06 +0100	[thread overview]
Message-ID: <87h84psadl.fsf@tcd.ie> (raw)
In-Reply-To: <b4mzhirx3hv.fsf@jpl.org>

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>>
>>> Some further changes are needed to fully support the help-echo property.
>>> Firstly, help-echo functions expect an overlay as their second argument
>>> when the object that had the property is an overlay (button).  Secondly,
>>> help-echo values can be forms in addition to strings and functions.
>>> Lastly, (info "(elisp) Button Properties") needs updating to reflect the
>>> supported values of the help-echo button property.
>>>
>>> The following patch should do all this.  I will push it in the next few
>>> days if there are no objections.  WDYT?
>>
>> Looks good to me.
>
> Thanks!  (The updated patch I just sent merely extends the tests.)

Now pushed to master:

Further improve button.el support for help-echo
0fc8177414 2019-10-03 23:05:14 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0fc8177414801e428ca184e8a9ba8b79a291c15a

Thanks,

-- 
Basil





      reply	other threads:[~2019-10-03 23:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26  1:14 bug#37515: 27.0.50; button.el doesn't support help-echo function Katsumi Yamaoka
2019-09-26  1:26 ` Katsumi Yamaoka
2019-09-26 13:49   ` Lars Ingebrigtsen
     [not found]     ` <esr-pdhHsyCqhSoZbW_3iLp4UdujyDpcbOuBdPROA9aG3j9CO0niyrK5O_Tf33N-le-e5hmaqbYZLyuNc6kd3A==@protonmail.internalid>
2019-09-26 21:44     ` Katsumi Yamaoka
2019-09-26 22:56       ` Jose A. Ortega Ruiz
2019-09-30 19:47         ` Basil L. Contovounesios
2019-09-30 19:53           ` Basil L. Contovounesios
2019-10-01 12:29             ` Basil L. Contovounesios
2019-10-01 12:28           ` Lars Ingebrigtsen
2019-10-01 12:32             ` Basil L. Contovounesios
2019-10-03 23:00               ` Basil L. Contovounesios [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h84psadl.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=37515@debbugs.gnu.org \
    --cc=jao@gnu.org \
    --cc=larsi@gnus.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.