From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#10856: 24.0.93; hs-hide-block changes cursor column when collapsing a comment Date: Thu, 03 Oct 2019 18:56:18 +0200 Message-ID: <87h84phiod.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="160137"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 10856@debbugs.gnu.org To: John Yates Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 03 18:57:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iG4Pk-000fXe-0d for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 18:57:16 +0200 Original-Received: from localhost ([::1]:38614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG4Pi-0001rs-VW for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 12:57:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58212) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG4PX-0001rd-Aw for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 12:57:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iG4PW-00067E-5x for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 12:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60410) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iG4PW-00067A-2K for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 12:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iG4PV-0003Dq-VU for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 12:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2019 16:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10856-submit@debbugs.gnu.org id=B10856.157012178512320 (code B ref 10856); Thu, 03 Oct 2019 16:57:01 +0000 Original-Received: (at 10856) by debbugs.gnu.org; 3 Oct 2019 16:56:25 +0000 Original-Received: from localhost ([127.0.0.1]:40995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG4Ou-0003Cd-JV for submit@debbugs.gnu.org; Thu, 03 Oct 2019 12:56:24 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:51984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG4Ot-0003CU-70 for 10856@debbugs.gnu.org; Thu, 03 Oct 2019 12:56:23 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iG4Oo-0001Zq-Jd; Thu, 03 Oct 2019 18:56:21 +0200 In-Reply-To: (John Yates's message of "Mon, 20 Feb 2012 09:02:25 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168249 Archived-At: John Yates writes: > When hs-show-block reveals a collapsed comment block it preserves the > position of the cursor. =C2=A0This honors the "principle of least > astonishment". By contrast when hs-hide-block collapses a comment > block it moves the cursor to the comment's left boundary. This is > unexpected and a jarring asymmetry w.r.t. hs-show-block. > > The following patch maintain the cursor column whenever possible: > > --- cur/hideshow.el > +++ fix/hideshow.el > @@ -552,11 +552,13 @@ > (defun hs-hide-comment-region (beg end &optional repos-end) > "Hide a region from BEG to END, marking it as a comment. > Optional arg REPOS-END means reposition at end." > - (let ((beg-eol (progn (goto-char beg) (line-end-position))) > + (let ((goal-col (current-column)) > + (beg-bol (progn (goto-char beg) (line-beginning-position))) > + (beg-eol (line-end-position)) > (end-eol (progn (goto-char end) (line-end-position)))) > (hs-discard-overlays beg-eol end-eol) > - (hs-make-overlay beg-eol end-eol 'comment beg end)) > - (goto-char (if repos-end end beg))) > + (hs-make-overlay beg-eol end-eol 'comment beg end) > + (goto-char (if repos-end end (min end (+ beg-bol goal-col)))))) I tried the patch, and it does indeed make the behaviour more logical, so I've now applied it to Emacs 27. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no