From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Whitton Subject: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query Date: Thu, 21 Nov 2019 14:37:44 -0700 Message-ID: <87h82wrjvb.fsf@iris.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: notmuch-bounces-gxuj+Tv9EO5zyzON3hdc1g@public.gmane.org Sender: "notmuch" To: emacs-orgmode-mXXj517/zsQ@public.gmane.org Cc: notmuch-gxuj+Tv9EO5zyzON3hdc1g@public.gmane.org List-Id: emacs-orgmode.gnu.org Dear maintainers, The function `org-notmuch-follow-link' in {org,ol}-notmuch.el calls `notmuch-show' with an arbitrary notmuch search query. However, the docstring for `notmuch-show' specifies that a notmuch thread ID, rather than an arbitrary notmuch query, should be supplied to `notmuch-show'. The effect of this is that the variable `notmuch-show-thread-id' may contain an arbitrary search query rather than a thread ID. That broke some code of mine which uses that variable. `org-notmuch-follow-link' needs to continue to accept an arbitrary query (as notmuch thread IDs are not stable), but it should convert it to a thread ID before passing it to `notmuch-show'. -- Sean Whitton