From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#38878: 26.3; EBDB fails to mark role as defunct Date: Sun, 12 Jan 2020 12:54:52 -0800 Message-ID: <87h810pf8j.fsf@ericabrahamsen.net> References: <871rshh8y7.fsf@disroot.org> <87ftgxpljn.fsf@ericabrahamsen.net> <87pnfo95kr.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="219304"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38878@debbugs.gnu.org To: Jorge P. de Morais Neto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 12 21:58:02 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iqkHO-000Zny-Nl for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Jan 2020 21:56:14 +0100 Original-Received: from localhost ([::1]:41730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqkHM-0007Za-Ve for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Jan 2020 15:56:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39697) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqkHE-0007Xz-Fj for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2020 15:56:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqkHC-0001Mn-BJ for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2020 15:56:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52140) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iqkHC-0001Ls-2f for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2020 15:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iqkHC-0007n7-2M for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2020 15:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Jan 2020 20:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38878 X-GNU-PR-Package: emacs Original-Received: via spool by 38878-submit@debbugs.gnu.org id=B38878.157886250229856 (code B ref 38878); Sun, 12 Jan 2020 20:56:02 +0000 Original-Received: (at 38878) by debbugs.gnu.org; 12 Jan 2020 20:55:02 +0000 Original-Received: from localhost ([127.0.0.1]:58112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqkGE-0007lO-0j for submit@debbugs.gnu.org; Sun, 12 Jan 2020 15:55:02 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:37678 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqkGC-0007kj-8Z for 38878@debbugs.gnu.org; Sun, 12 Jan 2020 15:55:01 -0500 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 16BB2FA00A; Sun, 12 Jan 2020 20:54:53 +0000 (UTC) In-Reply-To: <87pnfo95kr.fsf@disroot.org> (Jorge P. de Morais Neto's message of "Sun, 12 Jan 2020 10:17:56 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174518 Archived-At: Jorge P. de Morais Neto writes: > Em [2020-01-02 qui 13:59:08-0800], Eric Abrahamsen escreveu: > >> Hi, thanks for the report. I haven't been able to immediately >> reproduce this, but I'll take a look over the next couple of days and >> get back to you. > > Hi. If you could not reproduce the error, then perhaps you did not > press "E" on the same line as me. The error occurs when you press "E" > on the John line *within the ACME record*. Yesterday I managed to mark > the role as defunct by pressing "E" on the *organization's reference > that sits to the right of the person's name*. It seems that I was > pressing "E" on the wrong place. So it appears all you have to do is: > > 1. Clarify the manual. > 2. When the user presses "E" on the role field of a person in the > respective organization's record, then EBDB should either just work > or at least produce a clear and short error message. Oh, I see -- you're right I was doing this on the wrong line. Actually if you edit a role field on an organization using a "little edit" (with "e"), EBDB does some fancy footwork in the background to actually edit the role field on the person record. That didn't happen with the customize edit ("E") -- would you eval the following and confirm that it works correctly? (defun ebdb-edit-field-customize (record field) "Use the customize interface to edit FIELD of RECORD." (interactive (list (ebdb-current-record) (ebdb-current-field))) (let ((new-field (clone field))) (eieio-customize-object new-field) ;; If the user is editing a role field from an organization ;; record, do a switcharoo. (when (and (ebdb-record-organization-p record) (ebdb-field-role-p field)) (setq record (ebdb-gethash (slot-value field 'record-uuid) 'uuid))) ;; The following two variables are buffer-local, and we're hoping ;; this will make them local to the customization buffer: ie, an ;; arbitrary number of *Customize* buffers can be opened, and the ;; accept/apply options will all behave correctly. (setq ebdb-customization-field field ebdb-customization-record record)))