From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Jorge P. de Morais Neto <jorge+list@disroot.org>
Cc: 38878@debbugs.gnu.org
Subject: bug#38878: 26.3; EBDB fails to mark role as defunct
Date: Sun, 12 Jan 2020 12:54:52 -0800 [thread overview]
Message-ID: <87h810pf8j.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87pnfo95kr.fsf@disroot.org> (Jorge P. de Morais Neto's message of "Sun, 12 Jan 2020 10:17:56 -0300")
Jorge P. de Morais Neto <jorge+list@disroot.org> writes:
> Em [2020-01-02 qui 13:59:08-0800], Eric Abrahamsen escreveu:
>
>> Hi, thanks for the report. I haven't been able to immediately
>> reproduce this, but I'll take a look over the next couple of days and
>> get back to you.
>
> Hi. If you could not reproduce the error, then perhaps you did not
> press "E" on the same line as me. The error occurs when you press "E"
> on the John line *within the ACME record*. Yesterday I managed to mark
> the role as defunct by pressing "E" on the *organization's reference
> that sits to the right of the person's name*. It seems that I was
> pressing "E" on the wrong place. So it appears all you have to do is:
>
> 1. Clarify the manual.
> 2. When the user presses "E" on the role field of a person in the
> respective organization's record, then EBDB should either just work
> or at least produce a clear and short error message.
Oh, I see -- you're right I was doing this on the wrong line. Actually
if you edit a role field on an organization using a "little edit" (with
"e"), EBDB does some fancy footwork in the background to actually edit
the role field on the person record. That didn't happen with the
customize edit ("E") -- would you eval the following and confirm that it
works correctly?
(defun ebdb-edit-field-customize (record field)
"Use the customize interface to edit FIELD of RECORD."
(interactive
(list (ebdb-current-record)
(ebdb-current-field)))
(let ((new-field (clone field)))
(eieio-customize-object new-field)
;; If the user is editing a role field from an organization
;; record, do a switcharoo.
(when (and (ebdb-record-organization-p record)
(ebdb-field-role-p field))
(setq record (ebdb-gethash (slot-value field 'record-uuid) 'uuid)))
;; The following two variables are buffer-local, and we're hoping
;; this will make them local to the customization buffer: ie, an
;; arbitrary number of *Customize* buffers can be opened, and the
;; accept/apply options will all behave correctly.
(setq ebdb-customization-field field
ebdb-customization-record record)))
next prev parent reply other threads:[~2020-01-12 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 20:58 bug#38878: 26.3; EBDB fails to mark role as defunct Jorge P. de Morais Neto
2020-01-02 21:59 ` Eric Abrahamsen
2020-01-03 17:09 ` Jorge P. de Morais Neto
2020-01-03 21:09 ` Jorge P. de Morais Neto
2020-01-12 13:17 ` Jorge P. de Morais Neto
2020-01-12 20:54 ` Eric Abrahamsen [this message]
2020-01-13 17:07 ` Jorge P. de Morais Neto
2020-01-13 17:58 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h810pf8j.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=38878@debbugs.gnu.org \
--cc=jorge+list@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.