From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 263ab75: ; Fix recent byte-compiler warning in dnd.el again Date: Thu, 07 May 2020 21:21:23 +0100 Message-ID: <87h7wrmr7g.fsf@tcd.ie> References: <20200507174021.29070.24637@vcs0.savannah.gnu.org> <20200507174022.5B7BD20A15@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="17142"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 07 22:22:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWn23-0004Iz-VD for ged-emacs-devel@m.gmane-mx.org; Thu, 07 May 2020 22:22:11 +0200 Original-Received: from localhost ([::1]:36098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWn22-0007FZ-4i for ged-emacs-devel@m.gmane-mx.org; Thu, 07 May 2020 16:22:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWn1Y-0006ov-Ob for emacs-devel@gnu.org; Thu, 07 May 2020 16:21:40 -0400 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:32920) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWn1W-0007KE-G2 for emacs-devel@gnu.org; Thu, 07 May 2020 16:21:40 -0400 Original-Received: by mail-wr1-x42f.google.com with SMTP id h9so7979661wrt.0 for ; Thu, 07 May 2020 13:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8IvnQsZW5bnfHd6PK/ENuwgBYltXJlrCN3dw0HmX4uA=; b=kwCS8JUMFfVNgw6lis/ZG+EW3mT1dRPEByfxfaUcxqUZmkp5RDKSvI9WQ3HGBr9XBM FOgU/NTbn28kQqRE/owvrPId2LpeGKn5eMe1/rFIqZIa/8O/kHHm3LKuoHttvfpnHghB PMfJeRGDpuYFMNiVoUoJFqOCyOkwGwQTk01qdvFqjPVq9or/5AqBHWDtEqV5hGsRXfZe voIy9ZzdbYPbBaJdIZsG1kE/Xbs24AqvYdObFN6JF7nSf5DXSUbN7Wnw2k0gP1HdyMvm wnPQCIzHiZSd5dWuN5j+JFWsIqioaJ3S40KzT7OJkBXdH9MKqGsQ+M/C9H+kOJ6vNAJG 7CDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8IvnQsZW5bnfHd6PK/ENuwgBYltXJlrCN3dw0HmX4uA=; b=Zpf1NSLOZhNpIMyaPTHPg/WrPOuWSAAgsUhUroJ/QV6eX/HRoDeuUQf1vjiaT8Aov0 5JzSd/zt1UHmTHASLKq1XHdMPSL48JadoJST7Kcaf0sTDjCoNSUCg8jbNRL4RFuoPp0M xs4V15/T+ZeoOVyAYTBXAVqhJrvJ5GtrS16DQK/5aRCREo+tEofTp36r0/2wzE8UMulX 9KM0r3RkULG+bhcH11c0PjgfgQ6csATI0SPkSbNZjlIz9tzAWrfmbmLtc9HcTBUUD71n A/qRJTXMU1n2OOTXObdB8lab4lw4AiQYGq65spLARr4W+oK09fHK/qD1DgmlQ3Zk8CfR ef7g== X-Gm-Message-State: AGi0PuY/Vczfp3xrZ+qBBBPqvlwqOqBnad7jAeyjoz1fdX+sV+ui5BLR 4jYoG9ie7GiE9fqOur/LnhEksOyqck4= X-Google-Smtp-Source: APiQypLk3Rw9AcwXUYBCcyZQNTMAD3UnjK1oF74snu9e1b8R9ieganSbQgMU8yW9C5Xq4mOX+b65NQ== X-Received: by 2002:a5d:570c:: with SMTP id a12mr17354644wrv.80.1588882894881; Thu, 07 May 2020 13:21:34 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id q2sm4417304wrm.42.2020.05.07.13.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 13:21:34 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Thu, 07 May 2020 15:05:56 -0400") Received-SPF: none client-ip=2a00:1450:4864:20::42f; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249214 Archived-At: Stefan Monnier writes: >> diff --git a/lisp/dnd.el b/lisp/dnd.el >> index c185794..102bc75 100644 >> --- a/lisp/dnd.el >> +++ b/lisp/dnd.el >> @@ -101,6 +101,8 @@ is what has been dropped. Returns ACTION." >> (throw 'done t))) >> nil) >> (catch 'done >> + ;; Autoloaded but the byte-compiler still complains. >> + (declare-function browse-url-select-handler "browse-url" (url)) >> (let ((browser (browse-url-select-handler url))) >> (when browser >> (setq ret 'private) > > It complains because the ;;;###autoload cookie had not yet been turned > into an actual autoload in `lisp/loaddefs.el`. > IOW what was missing was `cd lisp; make autoloads`. That was my first thought as well, but 'make bootstrap' was still complaining after verifying $ grep browse-url-select-handler lisp/loaddefs.el (autoload 'browse-url-select-handler "browse-url" "\ so I assumed the warning was due to bootstrapping order and added the declaration anyway. > I also get caught by those things every once in a while. > It would be good to find a way to automatically guess when to run `make autoloads`. Is it run in time as part of 'make bootstrap'? -- Basil