From: Tassilo Horn <tsdh@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: lars ingebrigtsen <larsi@gnus.org>, 41133@debbugs.gnu.org
Subject: bug#41133: 28.0.50; Respect browse-url user options in shr/eww
Date: Fri, 08 May 2020 09:18:43 +0200 [thread overview]
Message-ID: <87h7wqlwrw.fsf@gnu.org> (raw)
In-Reply-To: <87wo5njkbq.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 08 May 2020 02:18:17 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> X-Debbugs-Cc: Lars Ingebrigtsen <larsi@gnus.org>, Tassilo Horn <tsdh@gnu.org>
> Severity: wishlist
> Tags: patch
>
> The commands shr-browse-url and eww-follow-link currently pass mailto
> URLs directly to browse-url-mail, which doesn't respect the user options
> browse-url-handlers and browse-url-mailto-function.
>
> Can't/shouldn't the commands call browse-url instead?
> WDYT of the attached patch that does this?
Looks good to me (I just looked at the parts calling browse-url), and I
think it won't change any behavior unless the user customizes
browse-url-handlers to catch mailto links with his own function instead
of the default one in browse-url-default-handlers (which in turn just
calls browse-url-mailto-function).
BTW: I didn't know about function-put. Should that be preferred to put?
I've tested that put/get also work with #'function, so where's the
difference?
Bye,
Tassilo
next prev parent reply other threads:[~2020-05-08 7:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 1:18 bug#41133: 28.0.50; Respect browse-url user options in shr/eww Basil L. Contovounesios
2020-05-08 6:37 ` Eli Zaretskii
2020-05-08 7:23 ` Tassilo Horn
2020-05-09 13:27 ` Basil L. Contovounesios
2020-05-09 13:42 ` Eli Zaretskii
2020-05-10 0:05 ` Basil L. Contovounesios
2020-05-10 13:52 ` Eli Zaretskii
2020-05-22 15:43 ` Basil L. Contovounesios
2020-05-08 7:18 ` Tassilo Horn [this message]
2020-05-09 13:32 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7wqlwrw.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=41133@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.