EWW Feature Request: Mark start and end of table cells?

EWW Feature Request: Mark start and end of table cells?

[T.V Raman]

Hi Lars,

This is a feature request specifically for emacspeak
(https://github.com/tvraman/emacspeak:

I'd like a way to be able to easily speak table cell contents and move
across table cells --up, left, right and down.

To do this reliably, I wonder if you could mark the   start and end of
table cells (td, th) via text properties in the  rendered buffer.

I tried to do this without touching code in shr (ie via advice) but
mostly failed because of how table rendering works at present.



-- 

Thanks,

--Raman
♉ Id: kg:/m/0285kf1  🦮

-- 

Thanks,

--Raman
♉ Id: kg:/m/0285kf1  🦮

Re: EWW Feature Request: Mark start and end of table cells?

[Lars Ingebrigtsen]

"T.V Raman" <raman@google.com> writes:

> I'd like a way to be able to easily speak table cell contents and move
> across table cells --up, left, right and down.

It'd be a nice feature in general -- I mean, getting the contents of a
table cell in shr, so that you can `C-w' the contents, for instance.

But it's difficult in general because of the way the tables are
rendered.  I guess one could put some text property on all the
characters in a cell to allow some command to put the text back together
again (say, `table-id #42351' or something), but I don't know what the
performance impact would be (and shr is plenty slow as it is).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: EWW Feature Request: Mark start and end of table cells?

[T.V Raman]

Thanks. Perhaps enable some type of configurable hook that allows for
experimentation? I'm just speculating at this point, as things stand,
even experimenting with such a feature is hard. Text properties would
be the easiest way to do it -- and if those properties dont have any
effect on rendering, they should be "invisible" both with respect to
display and performance to the user I hope Lars Ingebrigtsen writes:
 > "T.V Raman" <raman@google.com> writes:
 > 
 > > I'd like a way to be able to easily speak table cell contents and move
 > > across table cells --up, left, right and down.
 > 
 > It'd be a nice feature in general -- I mean, getting the contents of a
 > table cell in shr, so that you can `C-w' the contents, for instance.
 > 
 > But it's difficult in general because of the way the tables are
 > rendered.  I guess one could put some text property on all the
 > characters in a cell to allow some command to put the text back together
 > again (say, `table-id #42351' or something), but I don't know what the
 > performance impact would be (and shr is plenty slow as it is).
 > 
 > -- 
 > (domestic pets only, the antidote for overdose, milk.)
 >    bloggy blog: http://lars.ingebrigtsen.no

-- 
♉Id: kg:/m/0285kf1  🦮♉

--
♉Id: kg:/m/0285kf1  🦮♉

Re: EWW Feature Request: Mark start and end of table cells?

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1150 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:
See my present "poor man's solution" for browsing tables by cells:
https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-eww.el#L2375

I'm hanging the table-dom as a text property on the rendered table, and
the performance hit is not perceivable --- at least to me --- though it
might well be causing some kind of visual flicker by slowing the display 

> "T.V Raman" <raman@google.com> writes:
>
>> I'd like a way to be able to easily speak table cell contents and move
>> across table cells --up, left, right and down.
>
> It'd be a nice feature in general -- I mean, getting the contents of a
> table cell in shr, so that you can `C-w' the contents, for instance.
>
> But it's difficult in general because of the way the tables are
> rendered.  I guess one could put some text property on all the
> characters in a cell to allow some command to put the text back together
> again (say, `table-id #42351' or something), but I don't know what the
> performance impact would be (and shr is plenty slow as it is).

-- 

Thanks,

--Raman
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: EWW Feature Request: Mark start and end of table cells?

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 793 bytes --]

Hi Lars,

could you explain (perhaps via comments in the code for  posterity) the
meaning of the return value of shr-render-td-1 -- suspect this is where
the cell gets rendered and its rendered representation returned for
insertion in the output.

I used this markup:
<table><tr><td> sis is a test.</td></tr></table>
With this advice below:
(setq td-result  nil)

(defadvice shr-render-td-1 (after test pre act comp)
  (cl-declare (special td-result))
  (setq td-result ad-return-value)
  )

And td-result gets set to this list:

(7 7 1 (#("testing" 0 1 (shr-indentation 0))) 1 nil nil)
so (elt td-result 3) is the rendered cell, could you explain the meaning
of the other list elements in the returned value?
-- 

Thanks,

--Raman
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: EWW Feature Request: Mark start and end of table cells?

[Lars Ingebrigtsen]

"T.V Raman" <raman@google.com> writes:

> Thanks. Perhaps enable some type of configurable hook that allows for
> experimentation? I'm just speculating at this point, as things stand,
> even experimenting with such a feature is hard.

You can just put whatever functions you want into
`shr-external-rendering-functions' and write whatever code you want.
You don't have to render <table> as tabular data -- I imagine that for
emacspeak it might make sense to just render each <td> as a paragraph.
At least in some circumstances -- where <table> is used for layout and
not actual tabular data.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: EWW Feature Request: Mark start and end of table cells?

[Lars Ingebrigtsen]

"T.V Raman" <raman@google.com> writes:

> (7 7 1 (#("testing" 0 1 (shr-indentation 0))) 1 nil nil)
> so (elt td-result 3) is the rendered cell, could you explain the meaning
> of the other list elements in the returned value?

The return value (at the end of the function) should be pretty
self-explanatory:

      (list max-width
	    natural-width
	    (count-lines (point-min) (point-max))
	    (split-string (buffer-string) "\n")
	    (if (dom-attr dom 'colspan)
		(string-to-number (dom-attr dom 'colspan))
	      1)
	    (cdr (assq 'color shr-stylesheet))
	    (cdr (assq 'background-color shr-stylesheet))))))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: EWW Feature Request: Mark start and end of table cells?

[T.V Raman]

Hi Lars,

You're right in a way, but not quite. For linearizing tables etc, I
already have xslt magic.
Also the web has evolved where complex visual layout is now achieved
via lots of divs and spans rather than lots of nested tables (note I
said has changed, not necessarily changed for the better).

For now what I'm looking for is to turn data tables into something
that is more than just screen-deep.
Lars Ingebrigtsen writes:
 > "T.V Raman" <raman@google.com> writes:
 > 
 > > Thanks. Perhaps enable some type of configurable hook that allows for
 > > experimentation? I'm just speculating at this point, as things stand,
 > > even experimenting with such a feature is hard.
 > 
 > You can just put whatever functions you want into
 > `shr-external-rendering-functions' and write whatever code you want.
 > You don't have to render <table> as tabular data -- I imagine that for
 > emacspeak it might make sense to just render each <td> as a paragraph.
 > At least in some circumstances -- where <table> is used for layout and
 > not actual tabular data.
 > 
 > -- 
 > (domestic pets only, the antidote for overdose, milk.)
 >    bloggy blog: http://lars.ingebrigtsen.no

-- 
♉Id: kg:/m/0285kf1  🦮♉

--
♉Id: kg:/m/0285kf1  🦮♉