From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44341: 27.1; define-minor-mode generates inaccurate docstring Date: Mon, 02 Nov 2020 16:35:09 +0100 Message-ID: <87h7q76ac2.fsf@gnus.org> References: <87361u64oo.fsf@thb.lt> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16462"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44341@debbugs.gnu.org, Thibault Polge , Stefan Monnier To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 02 16:36:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZbsR-00048X-62 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 16:36:11 +0100 Original-Received: from localhost ([::1]:36678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZbsQ-00032c-5r for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 10:36:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZbsI-00032R-Pw for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 10:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58873) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZbsI-0001OJ-Gj for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 10:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZbsI-00038n-D0 for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 10:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Nov 2020 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44341-submit@debbugs.gnu.org id=B44341.160433132212009 (code B ref 44341); Mon, 02 Nov 2020 15:36:02 +0000 Original-Received: (at 44341) by debbugs.gnu.org; 2 Nov 2020 15:35:22 +0000 Original-Received: from localhost ([127.0.0.1]:42186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZbrd-00037d-On for submit@debbugs.gnu.org; Mon, 02 Nov 2020 10:35:21 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:48472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZbrc-00037P-E5 for 44341@debbugs.gnu.org; Mon, 02 Nov 2020 10:35:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XxLOh5S/cDNjJAEUiel2k5vitZXPy3SmxKNuN3hyE7o=; b=bhYDjSYzXag+BTDKuXXFyUs2m/ EOce/iPnSmnQMKpLJhErpY5tnV9OpLLTXcD7rxmx/mOSiUS9RFNQN4p1STFdyAQ7CcXoNL0fdBRVi jRnoBUGoN2w170DuX56tIXyvtSrfmDxKKE61nDl7TWscGuwcXdEjS97E9SMH0pxjuuN8=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZbrS-0001wI-NK; Mon, 02 Nov 2020 16:35:13 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXftaDTkHOeamBJ Nj+GeIP///9UTBKyAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QLAg47MxUkqYoAAAGFSURBVDjLbZQN bsMgDIXN1gMAu8Cwd4DVzgGqJfc/055NkkJaS5Uqf/jvGUKU6YNb6VaZuRHs0ygR8QSWG8DNKGeA chiAbkSJjUo+MlEHtoFsRvUokSl1sGwPopWYhMOLzFHEPORPqCVB8eytUI9wsAr9VgAEwZ/cD4Bc q9E9gGnJpYjtpmKkVVpJYmgAh/2MA7S71BW+KncqTiv3kIjgMKrGLbpyEwDzEg4Uf84yDqquD7QF sNppBHfhWlrKtZXbj+gJWH2ukqhy8ol4BNCkhMh9wg4wW8nQD8d9yDoBNwch8BWUWGQdUlmsoxVx sGsygsQawJ4gVp5TrP4VIJVcge8iQekQV0bQsHMxe6q+Azhyqu/AXtVFkwmoLyjmuwI+zSYAhdk1 H/wH8J/YaB2oXtwH6MPzO8DjDCPQqfITaPfKDNhBXI+53e+AjBvOUyo8ppjd7+mYKvuj1iA6RcC+ /KH4Q7YLwODSk12BR+h0/gTzcAcQ4xcNLT4oS2J+F2G/VF9C/gEWf6lMTPjvrwAAACV0RVh0ZGF0 ZTpjcmVhdGUAMjAyMC0xMS0wMlQxNDo1OTo1MSswMDowMAfa8TcAAAAldEVYdGRhdGU6bW9kaWZ5 ADIwMjAtMTEtMDJUMTQ6NTk6NTErMDA6MDB2h0mLAAAAAElFTkSuQmCC X-Now-Playing: Richard And Linda Thompson's _Pour Down Like Silver_: "Dimming Of The Day-Dargai" In-Reply-To: (Philipp Stephani's message of "Mon, 2 Nov 2020 13:28:06 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192528 Archived-At: Philipp Stephani writes: >> > disable ; Should disable (as a random symbol) >> > disable ; Again >> > "What?" ; Same. >> >> These should be considered as errors. Whether we catch them and signal >> an error or silently do something else is not particular important >> to me. > > We should definitely signal an error here. A form such as (my-mode > 'enable) actually disabling the mode is very confusing. The mode > function needs to check for the various cases anyway, it might as well > use `cond' and signal an error in the non-matching case. We can't signal an error here -- ARG has been documented to accept these values, and starting to signal an error would break a lot of people's code. (Now, ARG has been documented to work exactly opposite of the way it really works for these values, but that's a different wrinkle.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no