From: "João Távora" <joaotavora@gmail.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 44629@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#44629: 28.0.50; Eglot noisy with gfm-view-mode and view-read-only
Date: Tue, 17 Nov 2020 22:55:50 +0000 [thread overview]
Message-ID: <87h7pnk2yx.fsf@gmail.com> (raw)
In-Reply-To: <87pn4b68p1.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 17 Nov 2020 20:15:54 +0000")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
>> This doesn't change the fact that jsonrpc.el's use of `read-only-mode`
>> should probably be replaced by a simple setting of buffer-read-only,
>> but it could avoid the change to eglot when it calls `gfm-view-mode`.
>> Though maybe that change could be there, too.
>
> See my thoughts above on why Eglot needn't be changed in this regard.
They make sense.
> How's the attached patch for view.el and jsonrpc.el?
Looks good, and the mini-refactoring in jsonrpc.el is also welcome.
IMO, this doesn't need to be called out in NEWS. But let's hear from
Lars.
João
next prev parent reply other threads:[~2020-11-17 22:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 10:58 bug#44629: 28.0.50; Eglot noisy with gfm-view-mode and view-read-only Basil L. Contovounesios
2020-11-14 11:15 ` Basil L. Contovounesios
2020-11-14 12:02 ` Eli Zaretskii
2020-11-14 12:26 ` Basil L. Contovounesios
2020-11-14 14:46 ` Eli Zaretskii
2020-11-14 15:13 ` João Távora
2020-11-15 20:27 ` Juri Linkov
2020-11-15 21:52 ` Basil L. Contovounesios
2020-11-15 23:14 ` João Távora
2020-11-17 20:15 ` Basil L. Contovounesios
2020-11-17 20:21 ` Basil L. Contovounesios
2020-11-17 22:55 ` João Távora [this message]
2020-11-28 21:27 ` Basil L. Contovounesios
2020-11-29 10:36 ` Lars Ingebrigtsen
2020-12-03 15:26 ` Basil L. Contovounesios
2020-11-16 9:14 ` Juri Linkov
2020-11-14 13:47 ` João Távora
2020-11-14 17:13 ` Basil L. Contovounesios
2020-11-15 9:55 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7pnk2yx.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=44629@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.