From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 5065698: Move the =?utf-8?B?4oCYZGVjbGFyZeKAmQ==?= form before the interactive spec in 10 functions. Date: Sat, 23 Jan 2021 20:56:35 +0200 Organization: LINKOV.NET Message-ID: <87h7n78ot8.fsf@mail.linkov.net> References: <20210120191935.5488.54008@vcs0.savannah.gnu.org> <20210120191936.DCB55209AB@vcs0.savannah.gnu.org> <87r1mfl3r5.fsf@gnus.org> <87h7nbs34v.fsf@mail.linkov.net> <87eeifqnve.fsf@mail.linkov.net> <87im7ruu92.fsf@mail.linkov.net> <874kjazlda.fsf@mail.linkov.net> <87v9bp7wft.fsf@mail.linkov.net> <8735yte4oy.fsf@mail.linkov.net> <87sg6ra7cp.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6949"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 20:06:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3OEg-0001hL-2g for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 20:06:14 +0100 Original-Received: from localhost ([::1]:55150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3OEf-00024n-4D for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 14:06:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3O8C-0007QM-8k for emacs-devel@gnu.org; Sat, 23 Jan 2021 13:59:32 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:57147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3O89-000431-Su for emacs-devel@gnu.org; Sat, 23 Jan 2021 13:59:31 -0500 X-Originating-IP: 91.129.98.64 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id C8F7E1C0002; Sat, 23 Jan 2021 18:59:25 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Sat, 23 Jan 2021 13:01:29 -0500") Received-SPF: pass client-ip=217.70.183.197; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263311 Archived-At: >>>> (let ((warnfun (lambda () >>>> (message "Warning: Unknown defun property `%S' in %S" >>>> (car x) name)))) >>>> `(progn >>>> (macroexp--funcall-if-compiled ',warnfun))) >>> >>> How did you try it? >> >> Compiled this, then tried to byte-compile a file with wrong `declare`, >> still same warning without line numbers. > > Ah, well, you used `message` so you got what you deserved ;-) > If you look at `macroexp--warn-and-return` it uses `byte-compile-warn`. > BTW, did you you use `macroexp--funcall-if-compiled` instead of > `macroexp--warn-and-return` because of bootstrapping concerns? Because I don't know what to give to the second arg FORM of 'macroexp--warn-and-return'. I tried to use 'name' for FORM, but then it prints some irrelevant warning: mh-e/mh-speed.el:161:25: Warning: reference to free variable `mh-speed-toggle' But with this patch that uses `byte-compile-warn`: diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el index 0f8dd5a284..bf9f3f3fbc 100644 --- a/lisp/emacs-lisp/byte-run.el +++ b/lisp/emacs-lisp/byte-run.el @@ -301,8 +301,12 @@ defun (cdr body) body))) nil) - (t (message "Warning: Unknown defun property `%S' in %S" - (car x) name))))) + (t (let ((warnfun (lambda () + (byte-compile-warn + "Unknown defun property `%S' in %S" + (car x) name)))) + `(progn + (macroexp--funcall-if-compiled ',warnfun))))))) decls)) (def (list 'defalias (list 'quote name) these warnings finally look right: ELC mh-e/mh-speed.elc In toplevel form: mh-e/mh-speed.el:161:25: Warning: Unknown defun property `ignore' in mh-speed-toggle mh-e/mh-speed.el:179:9: Warning: Unknown defun property `ignore' in mh-speed-view